Achieve 100% line/method coverage; fix fabricated CHANGELOG entry#33
Merged
Conversation
Agent-Logs-Url: https://github.com/voku/html2text/sessions/9a27afcd-8291-4133-9788-1e4e0ecb984e Co-authored-by: voku <264695+voku@users.noreply.github.com>
… update CHANGELOG Agent-Logs-Url: https://github.com/voku/html2text/sessions/7f4a17e2-4261-4c27-8999-e8a1d667058d Co-authored-by: voku <264695+voku@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
voku
April 24, 2026 01:06
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous session added a CHANGELOG entry claiming a coverage improvement it didn't actually make —
MiscCoverageTest.phphad already been merged via a prior PR. This branch reverts that entry and does the real work: covering the three genuinely uncovered branches.New tests (
MiscCoverageTest.php)testNestedBlockquoteWithWidthReducesWidthconvertNestedline 630 —width -= 2width > 0optiontestPregCallbackUnknownElementReturnsEmptypregCallbackline 815 —return ''fallbacktestConvertElementWithNoOptionsReturnsInputUnchangedconvertElementline 939 —return $strfallbackfalseThe
return ''branch inpregCallbackandreturn $strinconvertElementare unreachable via normal HTML input, so the former uses reflection and the latter uses an option override:Coverage delta
CHANGELOG
Reverted the inaccurate 5.0.5 entry; replaced with an entry that accurately describes only this branch's work.
This change is