Repository navigation
fix(styles): restore font faces after TanStack Start rewrite - #149
Merged
Merged
Conversation
The @font-face rules for every selectable font (and their Preview families) were only imported by the deleted legacy tailwind.css entry. app.css never picked them up, so only the standalone Roboto Mono and Lexend Deca faces loaded and every other font fell back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Storybook imports app/app.css, which now carries the generated font faces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Guards against the font face import being dropped again when entry stylesheets move. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
app/app.css now imports oxytype-fonts.css; Storybook no longer does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every selectable font was broken. The generated
@font-facerules (oxytype-fonts.css, including the* Previewfamilies) were only imported by the legacytailwind.cssentry, which got deleted in the Start migration.app/app.cssnever imported them, so only the standalone Roboto Mono/Lexend Deca faces loaded and everything else fell back.Fix
oxytype-fonts.cssinapp/app.cssapp.css, which already importsapp/app.cssVerification
vp test run __tests__/vite-plugins/font-styles.spec.ts: 3 passedvp build: the clientapp-*.csscontains 86@font-facerules (e.g. Fira Code + Fira Code Preview)document.fontsregisters 86 faces;"Fira Code"and"Fira Code Preview"load🤖 Generated with Claude Code