Validate native geometry values on import - #9180
Open
HarukiMoriarty wants to merge 3 commits into
Open
Conversation
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Merging this PR will not alter performance
Comparing Footnotes
|
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Contributor
Author
|
Temporary close. |
Contributor
Author
|
Let's bring this back and see if more reasonable. |
Codecov Report❌ Patch coverage is ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation policy
Validation overhead benchmark
Each pair uses identical Arrow arrays, storage conversion, and extension wrapping. The only added work in
Withis the production validator.The high Point and Rect ratios compare a full buffer scan with a sub-microsecond zero-copy wrapper that never reads coordinate data. Over roughly one million coordinates or rows, the absolute validation cost is about 0.18-0.47 ns per coordinate/row, with 53-91 GB/s dense scan throughput. Sparse Point is slower because its regular null pattern creates about 105,000 short valid runs.