Skip to content

Don't store min/max_is_truncated in zone maps for non-string columns #9206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myrrc wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −37
Open

Don't store min/max_is_truncated in zone maps for non-string columns #9206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 6 additions & 37 deletions vortex-layout/src/layouts/file_stats.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@ use itertools::Itertools;
use parking_lot::Mutex;
use vortex_array::ArrayRef;
use vortex_array::ExecutionCtx;
use vortex_array::IntoArray;
use vortex_array::VortexSessionExecute;
use vortex_array::aggregate_fn::fns::sum::sum;
use vortex_array::arrays::ConstantArray;
use vortex_array::arrays::StructArray;
use vortex_array::arrays::struct_::StructArrayExt;
use vortex_array::builders::ArrayBuilder;
Expand Down Expand Up @@ -300,21 +298,9 @@ impl StatsArrayBuilder for StatNameArrayBuilder {
}

fn finish(&mut self) -> NamedArrays {
let array = self.builder.finish();
let len = array.len();
match self.stat {
Stat::Max => NamedArrays {
names: vec![self.stat.name().into(), MAX_IS_TRUNCATED.into()],
arrays: vec![array, ConstantArray::new(false, len).into_array()],
},
Stat::Min => NamedArrays {
names: vec![self.stat.name().into(), MIN_IS_TRUNCATED.into()],
arrays: vec![array, ConstantArray::new(false, len).into_array()],
},
_ => NamedArrays {
names: vec![self.stat.name().into()],
arrays: vec![array],
},
NamedArrays {
names: vec![self.stat.name().into()],
arrays: vec![self.builder.finish()],
}
}
}
Expand Down Expand Up @@ -522,6 +508,7 @@ impl FileStatsAccumulator {
#[cfg(test)]
mod tests {
use rstest::rstest;
use vortex_array::IntoArray;
use vortex_array::array_session;
use vortex_array::arrays::BoolArray;
use vortex_array::arrays::bool::BoolArrayExt;
Expand Down Expand Up @@ -602,7 +589,7 @@ mod tests {
}

#[test]
fn always_adds_is_truncated_column() {
fn fixed_width_stats_omit_is_truncated_columns() {
let mut ctx = array_session().create_execution_ctx();
let array = buffer![0, 1, 2].into_array();
let mut acc = StatsAccumulator::new(array.dtype(), &[Stat::Max, Stat::Min, Stat::Sum], 12);
Expand All @@ -614,25 +601,7 @@ mod tests {
.expect("Must have stats table");
assert_eq!(
stats_table.names().as_ref(),
&[
Stat::Max.name(),
MAX_IS_TRUNCATED,
Stat::Min.name(),
MIN_IS_TRUNCATED,
Stat::Sum.name(),
]
&[Stat::Max.name(), Stat::Min.name(), Stat::Sum.name()]
);
let field1_bool = stats_table
.unmasked_field(1)
.clone()
.execute::<BoolArray>(&mut ctx)
.unwrap();
assert_eq!(field1_bool.to_bit_buffer(), BitBuffer::from(vec![false]));
let field3_bool = stats_table
.unmasked_field(3)
.clone()
.execute::<BoolArray>(&mut ctx)
.unwrap();
assert_eq!(field3_bool.to_bit_buffer(), BitBuffer::from(vec![false]));
}
}
Loading