Skip to content

feat(vortex-geo): add collect scalar function - #9218

Open
HarukiMoriarty wants to merge 2 commits into
nemo/geo-areafrom
nemo/geo-collect
Open

feat(vortex-geo): add collect scalar function#9218
HarukiMoriarty wants to merge 2 commits into
nemo/geo-areafrom
nemo/geo-collect

Conversation

@HarukiMoriarty

@HarukiMoriarty HarukiMoriarty commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add strict homogeneous ST_Collect overloads for lists of Point, LineString, and Polygon
  • return the corresponding native MultiPoint, MultiLineString, or MultiPolygon type
  • use shared unary dispatch for constant handling and strict outer-null propagation
  • reuse geometry storage on the all-valid path and compact only nullable inner elements
  • add focused tests and a dedicated microbenchmark

Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
@HarukiMoriarty HarukiMoriarty added the changelog/feature A new feature label Aug 5, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 21.83%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1903 untouched benchmarks
🆕 4 new benchmarks
⏩ 43 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation decompress[u64, (1000, 16)] 73.5 µs 134.6 µs -45.39%
Simulation compress_fsst[(1000, 64, 8)] 1.2 ms 1 ms +11.88%
🆕 Simulation linestrings N/A 212.3 µs N/A
🆕 Simulation nullable_points N/A 408.7 µs N/A
🆕 Simulation points N/A 209 µs N/A
🆕 Simulation polygons N/A 208.6 µs N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing nemo/geo-collect (cbdcade) with nemo/geo-area (7040417)

Open in CodSpeed

Footnotes

  1. 43 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant