Skip to content

feat(vortex-geo): add intersection scalar function - #9220

Open
HarukiMoriarty wants to merge 3 commits into
nemo/geo-convex-hullfrom
nemo/geo-intersection-native
Open

feat(vortex-geo): add intersection scalar function#9220
HarukiMoriarty wants to merge 3 commits into
nemo/geo-convex-hullfrom
nemo/geo-intersection-native

Conversation

@HarukiMoriarty

@HarukiMoriarty HarukiMoriarty commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Stacked on #9219.

Summary

  • add native polygonal intersection overloads backed by geo::BooleanOps: Polygon × Polygon, Polygon × MultiPolygon, MultiPolygon × Polygon, and MultiPolygon × MultiPolygon
  • return a native 2D MultiPolygon for every overload
  • preserve constant/column execution and strict null propagation through the existing binary dispatcher
  • add Q9-oriented coverage for overlap, disjoint, boundary-touching, holes, constants, nulls, and all four input-type combinations
  • add focused rectangle and detailed-boundary microbenchmarks

NaN/invalid-coordinate checking remains outside the default execution path, consistent with the rest of the native geo scalar stack.

Checks

  • cargo +nightly fmt --all
  • cargo test -p vortex-geo (254 passed)
  • cargo clippy -p vortex-geo --all-targets --all-features -- -D warnings
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo bench -p vortex-geo --bench intersection
  • git diff --check

Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
@codspeed-hq

codspeed-hq Bot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 82.38%

⚡ 1 improved benchmark
✅ 1911 untouched benchmarks
🆕 3 new benchmarks
⏩ 43 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation decompress[u64, (1000, 16)] 134.6 µs 73.8 µs +82.38%
🆕 Simulation nullable_rectangles N/A 12.5 ms N/A
🆕 Simulation rectangles N/A 13.4 ms N/A
🆕 Simulation thirty_two_vertex_boundaries N/A 52.5 ms N/A

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing nemo/geo-intersection-native (af47d2b) with nemo/geo-convex-hull (ba1e979)

Open in CodSpeed

Footnotes

  1. 43 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant