Skip to content

fix(types): add parseResponseAttachments, keep deprecated alias - #1522

Open
MeGaurav4 wants to merge 3 commits into
vpulim:masterfrom
MeGaurav4:fix/1521-parseResponseAttachments-alias
Open

fix(types): add parseResponseAttachments, keep deprecated alias#1522
MeGaurav4 wants to merge 3 commits into
vpulim:masterfrom
MeGaurav4:fix/1521-parseResponseAttachments-alias

Conversation

@MeGaurav4

Copy link
Copy Markdown

Closes #1521

Reponse -> Response typo in the public option. Renaming outright
is a breaking change, so this keeps parseReponseAttachments as a
deprecated alias and makes the implementation check either:

parseResponseAttachments || parseReponseAttachments

Types: adds parseResponseAttachments as primary, marks the old
name @deprecated. Docs and tests updated to the correct spelling;
the old name remains in types and http as an alias check.

Also fixes enconding -> encoding in the encoding option docs.

Corrects Reponse -> Response typo. Adds the correctly spelled
parseResponseAttachments as primary, keeps parseReponseAttachments
as deprecated alias for back-compat (breaking rename otherwise).
Fixes enconding -> encoding in docs.

Closes vpulim#1521

Signed-off-by: MeGaurav4 <gaurav3.141592@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 66f74dc8-29f2-4a2f-89c3-364b8bd88bf3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@w666 w666 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeGaurav4 thanks for spotting and fixing it. Just one comment from me, could you please revert one couple of the tests changes just to make sure old deplrecatad one is used, and keep other tests use new one. This is just to make sure it is not broken in the future. Thanks.

@w666

w666 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Seems like code formatting is broken.

Signed-off-by: MeGaurav4 <gaurav3.141592@gmail.com>
@w666

w666 commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Hi @MeGaurav4,

I do understand that agentic coding is very tempting thing, but if it does not help you fixing the issues that is prabably not a good thing.

While in the last commit you fixed the formatting, the main comment left unresolved.

Per review feedback, keep one wsdl_options.json and one
response-encoding test on the old parseReponseAttachments name
so the deprecated alias stays covered, while the other cases use
the correct parseResponseAttachments.

Signed-off-by: MeGaurav4 <gaurav3.141592@gmail.com>
@MeGaurav4

Copy link
Copy Markdown
Author

Thanks for the review! Good call on keeping the deprecated alias covered. I kept one wsdl_options.json and one response-encoding test on the old parseReponseAttachments name so the alias stays tested, while the other cases use the correct parseResponseAttachments. Let me know if you would like both wsdl_options kept on the old name or any other tweak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in parseReponseAttachments, should be parseResponseAttachments

2 participants