fix(types): add parseResponseAttachments, keep deprecated alias - #1522
fix(types): add parseResponseAttachments, keep deprecated alias#1522MeGaurav4 wants to merge 3 commits into
Conversation
Corrects Reponse -> Response typo. Adds the correctly spelled parseResponseAttachments as primary, keeps parseReponseAttachments as deprecated alias for back-compat (breaking rename otherwise). Fixes enconding -> encoding in docs. Closes vpulim#1521 Signed-off-by: MeGaurav4 <gaurav3.141592@gmail.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
w666
left a comment
There was a problem hiding this comment.
@MeGaurav4 thanks for spotting and fixing it. Just one comment from me, could you please revert one couple of the tests changes just to make sure old deplrecatad one is used, and keep other tests use new one. This is just to make sure it is not broken in the future. Thanks.
|
Seems like code formatting is broken. |
Signed-off-by: MeGaurav4 <gaurav3.141592@gmail.com>
|
Hi @MeGaurav4, I do understand that agentic coding is very tempting thing, but if it does not help you fixing the issues that is prabably not a good thing. While in the last commit you fixed the formatting, the main comment left unresolved. |
Per review feedback, keep one wsdl_options.json and one response-encoding test on the old parseReponseAttachments name so the deprecated alias stays covered, while the other cases use the correct parseResponseAttachments. Signed-off-by: MeGaurav4 <gaurav3.141592@gmail.com>
|
Thanks for the review! Good call on keeping the deprecated alias covered. I kept one wsdl_options.json and one response-encoding test on the old parseReponseAttachments name so the alias stays tested, while the other cases use the correct parseResponseAttachments. Let me know if you would like both wsdl_options kept on the old name or any other tweak. |
Closes #1521
Reponse -> Response typo in the public option. Renaming outright
is a breaking change, so this keeps parseReponseAttachments as a
deprecated alias and makes the implementation check either:
parseResponseAttachments || parseReponseAttachments
Types: adds parseResponseAttachments as primary, marks the old
name @deprecated. Docs and tests updated to the correct spelling;
the old name remains in types and http as an alias check.
Also fixes enconding -> encoding in the encoding option docs.