Repository navigation
fix: keep Mermaid styles scoped to each diagram - #116
Closed
anabaarbosa wants to merge 2 commits into
Closed
anabaarbosa wants to merge 2 commits into
anabaarbosa wants to merge 2 commits into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#mermaid-idfrom the output.htmlLabels: false.dist.Why
Stripping the id turned Mermaid's theme CSS into global rules. Selectors such as
.label text, span, p { color: #142032 },.cluster span, p { color: #000 }andsvg { font-family: ... }leaked into the whole page. On the Developer Portal, 128 of 400 sampled article elements (p,code,strong,span) on Refresh token flow for headless implementations were rendered with the diagram colors instead of the article colors.With the id kept, Mermaid emits
#mermaid-<uuid> .label text, #mermaid-<uuid> span, ...and nothing leaks (verified on Help Center: 0 affected elements).Using a unique id also allows more than one diagram per page without the second one overriding the first.