docs(Select): fix double role=option in Item examples - #775
Merged
Conversation
Contributor
|
✅ Changeset found — this change will be included in the next release. Thanks! |
The Select compound and Item @examples spread slot attrs onto an inner div inside a non-renderless Item. SelectItem already binds those attrs (role=option, onClick) on its own Atom, so the documented usage rendered listbox > div[role=option] > div[role=option] — axe aria-required-parent (critical) — and double-fired the click handler. Bug-family sweep of components binding slotProps.attrs on a non-renderless Atom: - Combobox: same defect in both @examples — same correction - Treeview Cue/Checkbox/Indicator/SelectAll @examples and the docs treeview basic example spread attrs without renderless — added renderless - Radio Group/Root slot @examples spread attrs (duplicate role=radiogroup; Root also re-bound select alongside attrs.onClick) — added renderless, dropped the redundant handler - Clean: Selection/Single/Group/Presence examples (pure providers or renderless), Select/Combobox fixtures and docs examples Closes #738
johnleider
force-pushed
the
docs/select-item-double-option-738
branch
from
August 3, 2026 16:50
b3e561f to
5a609a3
Compare
johnleider
marked this pull request as ready for review
August 3, 2026 16:51
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #738
The Select compound and Item
@exampleblocks spread slotattrsonto an inner<div>inside a non-renderlessSelect.Item. The Item already binds those attrs (role="option",onClick) on its own Atom, so the documented usage renderedlistbox > div[role=option] > div[role=option]— axearia-required-parent(critical) — and double-fired the click handler. Fixed by putting content directly in the slot; the fixture and docs select examples already had the corrected shape.Bug-family sweep
Checked every component binding
slotProps.attrson a non-renderless Atom for the same@exampledefect:Same defect, fixed:
Combobox— both barrel@examples(compound + Item) had the identical inner-div spread; corrected the same way (Item highlight styling moved to adata-[highlighted]class on the component)Treeview— Cue/Checkbox/Indicator/SelectAll@examplesspread attrs withoutrenderless; addedrenderless(matches the docs example precedent). Same fix forTreeview.Cueinapps/docstreeviewbasic.vueRadio—RadioGroupslot@exampleduplicatedrole="radiogroup";RadioRootslot@examplespread attrs and re-boundselectalongsideattrs.onClick(triple-fire). Addedrenderless, dropped the redundant handlerChecked clean: Select/Combobox fixtures and all select/combobox docs examples (already corrected shape), Selection/Single/Group examples (pure context providers, no Atom), Presence (renderless by nature), Rating/Avatar/Image docs examples (already
renderless).Out of scope per issue: Select.Activator button-name (#613/#635) and the accessible-name mechanism (#610).
Verification
vitest --project v0:browser— a11y sweep + Select: 152 passedpnpm typecheck— green