chore: rebase Select a11y/typeahead (#635) onto dev tip - #822
Closed
johnleider wants to merge 3 commits into
Closed
Conversation
…ectActivator (closes #613)
Add browser tests for SelectActivator.label (aria-label prop) and the typeahead keyboard handler that delegates to useVirtualFocus.typeahead. The typeahead test mounts with attachTo: document.body so that items are in the live document and document.querySelector resolves element refs, which is required for applyHighlight to succeed. Add unit tests for useVirtualFocus.typeahead: forward search from current position, case-insensitive matching, wrap-around, disabled item skipping, no-match no-op, all-disabled early return, and el-less item handling.
johnleider
marked this pull request as ready for review
August 12, 2026 06:04
johnleider
marked this pull request as draft
August 16, 2026 22:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch carries the exact commits from PR #635 rebased onto the current
devtip.Purpose
PR #635 (Select a11y/typeahead) was 122 commits behind
dev. This branch brings it current without force-pushing to the contributor's fork.Changes
Cherry-picked from #635 (authored by @sridhar-3009):
feat(Select): add aria-label prop and printable-char typeahead to SelectActivatortest(select): add coverage for typeahead and aria-label featureschore: add changeset for Select aria-label and typeaheadCI Note
The original PR only ran sparse checks because
pr-checks.ymltriggers only on PRs targetingmaster, notdev. This PR targetsdevas well, so the same limitation applies. Consider updating.github/workflows/pr-checks.ymlto includedevin thebranchesarray for full CI coverage on feature PRs.Review
No code changes from #635. This is purely a rebase. Once merged, #635 can be closed as superseded.
Closes #610