fix(VMenu): submenu a11y/navigation improvements#22904
Draft
J-Sek wants to merge 4 commits into
Draft
Conversation
6756494 to
51d6d47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes nested submenus behave predictably under mixed keyboard + mouse use, instead of collapsing the whole tree to
document.bodyon an incidental hover-out.Behavior
mouseleaveshould not close the submenu unless the root menu opened with hover (aligns with other frameworks)document.bodyNotes
useActivatorgains anisSubmenuflag (plumbed via an internal_submenuprop onVOverlay) so the hover-chain logic applies only to actual submenusVMenuSymbolnow tracks open children by id + close handle, enabling per-level replacement and subtree collapseMarkup: