fix(VFileInput): show drag feedback for file drops#22909
Open
mahsarajabpour wants to merge 2 commits into
Open
fix(VFileInput): show drag feedback for file drops#22909mahsarajabpour wants to merge 2 commits into
mahsarajabpour wants to merge 2 commits into
Conversation
b5295b1 to
1b2007a
Compare
Contributor
I wonder if replacing the effect with simple dashed outline would help work around some of the problems. BTW. PR needs some playground so we can easily paste it locally to |
1b2007a to
3a53043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20576.
This improves drag-and-drop feedback in
v-file-input.The dragging state is now properly cleared when a file drag leaves the input, preventing the state from becoming stuck.
The previous feedback effect produced inconsistent results across variants (
filled,solo-filled, andsolo-inverted) and depended on the primary theme color. It has been replaced with a simple dashed outline that provides consistent drag feedback across variants and themes.Tests were updated to cover drag state cleanup and drag feedback behavior.
Markup