feat(VTreeview): add aria-label and aria-expanded to expand/collapse buttons#22946
Open
mmustafasenoglu wants to merge 2 commits into
Open
feat(VTreeview): add aria-label and aria-expanded to expand/collapse buttons#22946mmustafasenoglu wants to merge 2 commits into
mmustafasenoglu wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds accessibility attributes to the expand/collapse buttons in VTreeview. Screen readers will now announce "Expand [item]" / "Collapse [item]" instead of just "Button".
Fixes #21585
Motivation
Currently, screen readers announce the expand/collapse buttons in VTreeview simply as "Button" without any context about what the button does. This makes the treeview inaccessible for users relying on assistive technologies.
Changes
isOpenprop toVTreeviewItemto receive the open state from parentVTreeviewGroupnow passes itsisOpenstate toVTreeviewItemvia defaultsaria-label("Expand [title]" / "Collapse [title]") to the toggle buttonaria-expandedattribute to indicate the current stateBefore
After