Repository navigation
chore(vesting): remove orphan files + fix CI avm install - #36
Merged
Merged
Conversation
These files were left behind after PR #35 renamed the modules to error.rs and state.rs to align with the staking program. They were not declared in lib.rs and not referenced anywhere, so they had no effect on the build, but they cluttered the source tree.
PetarStoev02
changed the title
The solana job's working-directory is solana/<package>, which contains
a rust-toolchain.toml pinning rustc to 1.89.0. When cargo install runs
from there, rustup respects the pin and uses 1.89 instead of the
stable toolchain installed by dtolnay/rust-toolchain@stable.
avm's transitive dep cargo-platform@0.3.3 requires rustc 1.91+, so the
install fails with "rustc 1.89.0 is not supported".
Overriding working-directory to ${{ github.workspace }} (repo root,
no rust-toolchain.toml) for the CLI installs makes them use the
dtolnay-installed stable. The per-package rust-toolchain.toml still
applies to the subsequent anchor build/test steps.
PetarStoev02
force-pushed
the
chore/vesting-remove-orphan-files
branch
from
June 26, 2026 10:10
5cb36cf to
3d7dad8
Compare
…onflict anchor-bankrun@0.5.0 declares a peer dep on @coral-xyz/anchor@^0.30.0, but the vesting package depends on @coral-xyz/anchor@^0.32.1. The peer dep is soft (the bankrun API is stable across 0.30-0.32), but npm ci refuses to install without acknowledging the mismatch. Scoped to solana/vesting only via local .npmrc so other packages are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated cleanups, bundled because the CI fix is needed to land either change on a green branch.
1. Remove orphan files (follow-up to #35)
Removes two source files left over from the module renames (
errorstoerror,statestostate) done during review:programs/vesting/src/errors.rsprograms/vesting/src/states.rsNeither was declared in
lib.rsand neither is referenced anywhere in the crate, so this has no functional effect. Pure source-tree cleanup.2. Fix CI: avm install MSRV mismatch
The
Install Anchorstep has been failing on every recent PR and on main:Root cause: the solana job's
working-directoryissolana/<package>(e.g.solana/staking), which contains arust-toolchain.tomlpinning rustc to1.89.0. Whencargo install ... avmruns from there, rustup uses the pinned 1.89 instead of the stable toolchain installed bydtolnay/rust-toolchain@stable. avm's lockfile pinscargo-platform@0.3.3, which requires rustc 1.91+.Fix: override
working-directoryto${{ github.workspace }}for the CLI installs (avm, surfpool). The repo root has norust-toolchain.toml, so cargo uses the dtolnay-installed stable. The per-package pin still applies to the subsequentanchor build/anchor teststeps, so the program builds with the same toolchain as before.Verification
Test plan
rgconfirms no references to deleted modules