fix:fallback theme styles for browsers without light-dark() support - #462
Closed
As-ajay06 wants to merge 3 commits into
Closed
Conversation
Member
|
Closing, see #426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #426
Description
Add fallback theme styles for browsers without light-dark() support
AI usage
AI has been for drafting in this issue , and researching the browser part.
Also regarding new changes to the issue
the CSS light-dark() function is a relatively new feature and achieved baseline support across major modern browsers around May 2024.
Here is the breakdown of which older versions will NOT run this feature (i.e. they do not support light-dark()):