Move theme, language, and copy switchers to the burger menu (#199) - #467
Open
Raghaddahi wants to merge 3 commits into
Open
Move theme, language, and copy switchers to the burger menu (#199)#467Raghaddahi wants to merge 3 commits into
Raghaddahi wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #199
Description
Moves the theme toggle, copy button, and language selector out of
.page-tools(above the article content) and into the burger menu overlay on mobile, so they no longer take up space above the content on small screens.Approach: render the tools in both places (
.page-toolsinbase.htmland.primary-nav__toolsinnavigation.html) and toggle visibility with CSS breakpoints — no JS DOM manipulation. The theme toggle button id was replaced with a.js-theme-toggleclass so the JS wires up both instances.Worth careful review:
.primary-navoverlay may clip instead of overlay content on mobile — verify on a narrow viewport.page/requestwere added to theheaderinclusion-tag context;requestis currently unused (kept defensively).Testing
AI usage