docs(agents): record W&B product and platform facts for style passes - #2986
Open
johndmulhausen wants to merge 3 commits into
Open
docs(agents): record W&B product and platform facts for style passes#2986johndmulhausen wants to merge 3 commits into
johndmulhausen wants to merge 3 commits into
Conversation
The style-guide skill reads AGENTS.md as a Pass 0 pre-flight for facts it cannot infer. Seven product and platform facts were enforced in review across 27 style PRs but never written down, so every pass re-litigated them. Prose and style rules are deliberately not added here: they are universal and live in the skill. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
📚 Mintlify Preview Links📝 Changed (1 total)⚙️ Other (1)
🤖 Generated automatically when Mintlify deployment succeeds |
A mobile app now exists, so "app" no longer identifies the web product.
Record "W&B" ("Weights & Biases" in full) as the name, and "W&B UI" for
the interface component when a sentence must distinguish it from the API
or SDK. Fix the two places this file said "W&B app" itself.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
style-guideskill now readsAGENTS.mdas a Pass 0 pre-flight for the product and platform facts it can't infer — product and package names, what a directory's content actually is, UI surface names, and which paths hold generated content. Across 27 style PRs, reviewers enforced these facts about ~400 times in line comments, but none of them were written down anywhere, so every style pass guessed, got corrected, and the next pass guessed again. This records the ones that are settled and substantiated.Prose and style rules were deliberately not added here. Voice, grammar, punctuation, list and heading form, link form, placeholder form, section naming, and word choice are universal — they must read the same in every docs repo, and they live in the skill. A per-repo prose override would make successive runs oscillate. The Deliberately not added section below lists the candidates rejected on that basis, so you can see the boundary was applied on purpose. This PR also respects the delegation-shell architecture from #2735: no inline style rules come back.
What's recorded
All seven additions go into the existing W&B-specific conventions not in the skill list.
wandbis the W&B Python SDK; full form "the W&B Python SDK (wandb)", short form "thewandblibrary"wandbis the W&B Python SDK." Applied.models/sweeps/initialize-sweeps.mdx): "I don't think 'a W&B sweep' is a thing. W&B Sweeps is the product and a sweep is what it manages." Author applied it across all reviewed files.snippets/_includes/code-examples/,snippets/CodeSnippet.jsx, andtakeru-marked tables;weave/cookbooks/notebook sourcesAGENTS.mdwhich directories hold generated content. It recorded none, andAGENTS.mddoesn't reference README.md — so a pre-flight that reads "AGENTS.md plus any convention docs it references" never saw that table.Note on a sibling file
I only edited
AGENTS.md, per scope. Two things belong in files I didn't touch:/ref/python/and/weave/api-reference/, neither of which exists in the tree — that row set looks stale. I added a cross-reference to the table rather than copying it, so the two files can't drift apart, but the table itself needs an owner's pass..github/CODEOWNERSis a single catch-all line (* @wandb/docs-team). That's relevant to the first open question below.Deliberately not added (universal prose rules)
Each of these was enforced by a wandb reviewer, and each reads identically in any docs repo with different nouns — so it belongs in the skill, not here. Several are already there verbatim.
wandb(product performs actions, package doesn't)3-language-pass.md— which already useswandbas its own example — and4-terminology-pass.mddescription, and alt text; leave code identifiers alone4-terminology-pass.md;7-polish-pass.mdSKILL.md"When to stop and ask"SKILL.md,1-context-pass.md,2-structure-pass.md,8-audit-pass.md(four places)keywordsas a side effect of another change0-guardrails.md: "Never add or remove frontmatter fields."SKILL.md"When to stop and ask"0-guardrails.md"Hard exclusion zones"3-language-pass.md(first-use expansion). Also unsubstantiated: corpus prefers lowercase "Jupyter notebook" 35 to 18.4-terminology-pass.mdword list. Cited as a team decision by two reviewers (#2673, #2684) — still a universal word-choice rule.6-formatting-pass.md. Raised on #2724.4-terminology-pass.md. #2739 theme M.4-terminology-pass.md. Raised on #2673.**Term**:lead-ins on definition lists6-formatting-pass.md. 10 instances in #2739 theme D.7-polish-pass.md. #2687: "I wonder if the docs skill can be augmented to fix this" — exactly right, and that's where it went.7-polish-pass.md. #2739 theme I, #2727 P1/P2.1-context-pass.md,3-language-pass.md. Named twice on #2679.SKILL.md: "One voice for recommendations: 'we recommend.'" See open questions.6-formatting-pass.md. See open questions — genuinely contested here.keywordsskill.Open questions for the team
Nothing below is recorded in
AGENTS.md. A wrong rule in that file is worse than a missing one, since every agent session reads it.1. What is the web app called? Highest-value question here.
AGENTS.mdas saying the platform is "W&B"; the file says no such thing, before or after this PR. Its only mentions are incidental lowercase "the W&B app".<Tab title>labels to "App UI" and that merged.2.
keywords:— keep or remove? Nothing aboutkeywordsis recorded in this PR.keywordshunk on style: apply /style-guide pass to models/automations #2684; merged style: add frontmatter keywords to platform pages #2680 (83 platform pages) and WEAVE: Adds keywords frontmatter to prompt versioning doc #2774 add them on purpose; style: apply /style-guide pass to weave #2739 added them to 103 of 141 files with zero objections.keywordsas a side effect" as agreed by both camps. It isn't — style: apply /style-guide pass to models/automations #2684's 👍 was on an add, and style: apply /style-guide pass to weave #2739's 103-file add merged unopposed. That narrow rule is in any case covered universally by the skill's guardrail against adding frontmatter fields, so nothing is lost by leaving the question open here.3. Recommendation voice: "we recommend" vs "W&B recommends"?
view-agent-signals.mdx, @dbrian57 onevaluation_logger.mdx).AGENTS.mdoverride — that's what makes successive runs oscillate.4. "This page shows you how to…"
AGENTS.md.5. Casing of Weave domain objects in prose — Call, Op, Scorer, Model, Dataset, Evaluation, Thread, Signal, Agent, Trace.
description(view-call.mdx:3) and alt text (view-call.mdx:138).weave/**/*.mdxprose with code, headings, links, and bold stripped — traces 33 cap / 432 low, calls 69/380, spans 7/127, prompts 4/113, models 29/195, datasets 4/57, evaluations 19/99, scorers 27/73, agents 45/114. Recording the candidate as written would have licensed a ~1,700-instance recapitalization on the strength of 12 comments.weave/guides/tracking/view-agent-activity.mdx:18: "a row of tabs across the top: Dashboard, Agents, Conversations, Spans, and Signals. … the other tabs let you drill into individual agents, conversations, spans, and signals." Capitalized as labels, lowercase as nouns, one sentence apart.6. Placeholder syntax:
<your_api_key>or[YOUR-API-KEY]?<and>)" — the skill's square brackets were reverted across every login block. Their objection on style: apply /style-guide pass to models/runs #2724 is substantive, not aesthetic: "Don't use square brackets since it looks like we expect a list as an input."<password>to[PASSWORD]hours after the author cited an angle-bracket convention in the same PR.[TEAM_NAME]/[PROJECT_NAME]on one page and[YOUR-TEAM]/[YOUR-PROJECT]on another, while @anastasiaguspan wants[YOUR-TEAM]uniformly. All three forms are in main.7. May
weave/cookbooks/*.mdxbe hand-edited, and what do those pages call themselves?/weave/cookbooks/as generated fromwandb/weave("Edit the code in the source repo, not inwandb/docs"), but the.ipynbsources are tracked in this repo atweave/cookbooks/source/, the Colab links point atwandb/docs, and no script inscripts/or workflow in.github/workflows/regenerates the.mdx. Practice contradicts the table: style: apply /style-guide pass to weave #2739 hand-edited 19 cookbook pages and @dbrian57 committed suggestions straight into them.Intro_to_Weave_Hello_Trace.mdx:13has both, reviewer-approved, in adjacent sentences: "This notebook shows you how to capture your first trace… This tutorial targets developers who are new to Weave."8. Which pages are actually Eng/Legal-vetted? The candidate asked for a path list of vetted areas. I did not record one, because I couldn't substantiate it and a wrong no-touch zone over ~20 pages is exactly the kind of error that compounds.
models/runs/delete-runs.mdx: "Future: don't touch docs that revolve around data, security, and/or other sensitive info since in all likelihood they … went under careful scrutiny from the Eng Team or Legal." No path list, and the one page it names is one the reviewer flagged as unvalidated ("Someone would need to verify this/approve the wording") and deleted.platform/hosting/iam/sso.mdx— the largest candidate — is mostly third-party Azure and Okta click-through steps, not vetted compliance prose..github/CODEOWNERSis one catch-all line.9. Six live
<Important>blocks probably aren't rendering. Same bug class as #2886.<Important>has no local definition insnippets/*.jsxand isn't registered indocs.json, so these bodies may be reaching nobody:platform/hosting/self-managed/operator.mdx:1833platform/hosting/iam/access-management/restricted-projects.mdx:69weave/guides/evaluation/scorers.mdx:403weave/guides/tracking/create-call.mdx:175weave/guides/tracking/update-call.mdx:131snippets/_includes/self-managed-mysql-eol-upgrade.mdx:1(plus itsja/ko/frcopies)Worth a screenshot check the way #2886 did. Not fixed here — this PR only touches
AGENTS.md, and callout guidance has been removed from it at the maintainer's request.Verification
Every recorded claim was checked against the tree at
dfba8d0. Counts exclude localized content (ja/,ko/,fr/, andsnippets/{ja,ko,fr}/); 1,533 English.mdxpages.weave/**/*.mdx: as a bold UI label, in surface-label position (name followed by tab/view/page/table/panel/column/button/section), and in generic prose with frontmatter, headings, fenced and inline code, links, and bold spans stripped. Bold-label usage is capitalized 100% of the time — lowercase count is 0 for all 19 names tested. That's the settled fact, and it's what the bullet records. Generic prose runs lowercase for 17 of 19, which is why the bullet explicitly says not to recapitalize there. Playground (50 cap / 3 low) is the one name capitalized in prose too; it's in the list either way.platform/hosting/iam/sso.mdx:144,158,176,190,194are Microsoft Entra ID steps andplatform/hosting/monitoring-usage/slack-alerts.mdx:33is the Slack app config UI. A directory-scoped carve-out would have renamed those, and would have missed W&B non-project surfaces outsideplatform/(models/runs/tags.mdx:93"left sidebar of the Run page",models/track/project-page.mdx:378org nav). So the exclusions are scoped by what the surface is, not by path.release-notes/is excluded as dated historical content (4 competing hits).wandb)" 11; "thewandblibrary" 47; "wandbSDK" 4. The short form in the bullet follows the corpus (47), not the skill's guess.support/, 0 in the main docset, vs. "a sweep" 204 and "W&B Sweeps" 47 — roughly 50:1. The comment was pinned to fix: relocate Automations snippet includes and fix localized imports #2727 via the review-comments API. The anti-generalization clause is also counted: "a W&B run" 67, "a W&B artifact" 9, "a W&B report" 7 are live usage, so the rule is scoped to sweeps rather than swept across all three.weave/cookbooks/: all 19.mdxpages have a matching.ipynbunderweave/cookbooks/source/(29 tracked files there) and all 19 open with an interactive-notebook<Note>linking Colab and GitHub.takerumarkers confirmed atinference/models.mdx:15,48,56,inference/lora.mdx:116,inference/lifecycle.mdx:36,49,inference/response-settings/reasoning.mdx:21,serverless-training/available-models.mdx:11.snippets/code-examples/README.mddocuments thewandb/docs-code-evalsync and callssnippets/CodeSnippet.jsxauto-generated;scripts/sync_code_examples.shand thesync-code-examplesworkflow back it up. README.md's anchor#what-files-do-i-editverified.keywordsno-add process claim (open question 2), and prose-wide Weave capitalization (open question 5).🤖 Generated with Claude Code