Add SDC fault confidence levels and reporting - #2
Open
wangxumarshall wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
HPL_T_SDC_CONFIDENCEwithHPL_SDC_CONFIRMED,HPL_SDC_SUSPECTED,HPL_SDC_WARNINGand aconfidencefield toHPL_T_SDC_FAULTinhpl/include/hpl_sdc.h.HPL_sdc_log_fault_ex(...)(accepts confidence) and keepHPL_sdc_log_fault(...)as a wrapper that logs withHPL_SDC_SUSPECTED; update prototypes accordingly.hpl/src/sdc/HPL_sdc_report.cto record, gather and print confidence per fault, addHPL_sdc_confidence_str(...), and include a summary counts block for confidence levels in the aggregated report.HPL_sdc_classify_panel_entry(...)inhpl/src/sdc/HPL_sdc_verify.cthat maps NaN/Inf toCONFIRMEDand finite range overflow toSUSPECTED.CONFIRMED; non-NaN finite/overflow panel entry / floating checksum anomalies ->SUSPECTED(via classifier); panel NaN/Inf ->CONFIRMED(via classifier); panel range overflow ->SUSPECTED; back-solve NaN/Inf ->CONFIRMED; back-solve 6-sigma outliers ->WARNING.Testing
git diff --checkto validate whitespace and simple issues and fixed end-of-line normalization; this passed after fixes.gcc -DHPL_SDC_CHECK -DAdd__ -DF77_INTEGER=int -DStringSunStyle -I/tmp/hpl_fake_mpi -Ihpl/include -Ihpl/include/WSL_SDC_CHECK_ONLY -fsyntax-only <file>for all modified C files, using a minimal fakempi.h(typedefs for the MPI symbols used); these syntax-only checks succeeded.make -C hpl arch=WSL_SDC_CHECK_ONLY, but the build failed in this environment due to platform-specificMake.incsymlink resolution and missing platform Make.inc (environmental issue), so a full compile/link was not completed here.Codex Task