Repository navigation
docs: correct Bedrock OpenAI support and default-project access - #927
Merged
Merged
Conversation
Ground both local and cloud IAM examples in warp-terraform PR #1658 and keep the BYOLLM provider overview consistent. Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
This PR was generated with Warp. Comment |
bnavetta
reviewed
Oct 16, 2026
Apply the requested wildcard scope consistently to local and cloud IAM examples and remove their OpenAI-specific caveats. Co-Authored-By: Oz <oz-agent@warp.dev>
bnavetta
approved these changes
Oct 16, 2026
bnavetta
marked this pull request as ready for review
October 16, 2026 01:24
Contributor
Contributor
There was a problem hiding this comment.
Review summary
The independent agent completed its review for this commit.
Findings
- src/content/docs/enterprise/enterprise-features/byollm-aws-bedrock.mdx:59 — [IMPORTANT] The new Warp-specific OpenAI Bedrock support claim and sufficiency of the invoke-only policies could not be independently checked because the cited warp-server and warp-terraform revisions are inaccessible to this reviewer; AWS documentation confirms the default-project requirement, not Warp's routing or Responses operations. Requested resolution: provide the relevant pinned source excerpts or rerun this independent review with read access to the cited repositories so these claims can be verified. This is an evidence gap, not a demonstrated factual error or a requirement for pending human approval.
Verdict
Request changes
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Correct Bedrock BYOLLM documentation for supported Anthropic (Claude) and OpenAI models. Both local and cloud IAM examples now grant the existing invoke actions on the account's default project, with region/account wildcards matching the other resource ARNs. The local and cloud OpenAI-specific caveats are removed as requested in review.
The BYOLLM overview's Bedrock description and comparison row are kept consistent. No model list, new integration features, or Terraform changes are introduced.
Source grounding
bedrock:InvokeModelandbedrock:InvokeModelWithResponseStreamonarn:aws:bedrock:${var.aws_region}:${var.aws_account_id}:project/default.bedrock-runtime.warp-server/model/types/ai/types.go,logic/ai/llm/openai/responses_runtime.go, andlogic/ai/llm/openai/client/client.goat2bd51017278abd1c07f9e6f81525fa60de172753confirm Anthropic/OpenAI Bedrock routing support. Current availability is confirmed by the requester; source inspection alone is not deployment verification.Wildcard scope follows the requested review change.
Validation
npm run typecheck(0 errors, 7 existing hints),npm run test:heading-vars(5 tests),npm run build,npm run test:heading-tocs(3,381 entries / 397 HTML files), andnpm run test:homepage-json-ld.python3 .agents/skills/check_for_broken_links/check_links.py --internal-only(4,434 links, none broken) andgit diff --check.arn:aws:bedrock:*:*:project/defaultand preserve the two existing invoke actions and other resources.python3 .agents/skills/style_lint/style_lint.py --changed: 11 warnings, all independently matched to the pre-change baseline (2 buzzwords and 9 glossary warnings); no new warnings.check_compression_contract.py --content-type feature-doc: overview passes; Bedrock page remains over budget (2,473 words / 4 callouts versus baseline 2,476 / 4). The policy correction leaves the pre-existing callouts and setup structure unchanged; a broader rewrite is outside scope.trunk checkandtrunk fmt(trunkis not installed). No live AWS inference run was performed.Editorial scope
This is a factual correction, so the content-design plan is exempt. The reader's task and existing local/cloud setup structure remain intact. The deletion-only pass removed the unsupported Claude-only exclusion; the overview owns provider comparison while the Bedrock page owns IAM setup. No comments or verification-only files are added.
Unverified claims
None in the changed claims against the request and cited sources. This run did not verify live AWS execution, deployed server revision, or unrelated pre-existing page claims.
Documentation risk
Risk: engineering-review-required
Rationale: Changes provider-support claims and IAM permission examples. The pre-existing Bedrock length/callout overage is retained to avoid an unrelated page rewrite.
Source files consulted: warp-terraform/environments/aws-staging/oz_federation.tf@42482be78b265473d405d104c535f0b192e7dec9; warp-server (model/types/ai/types.go, logic/ai/llm/openai/responses_runtime.go, logic/ai/llm/openai/client/client.go)@2bd51017278abd1c07f9e6f81525fa60de172753
Requested engineering reviewers: none
Engineering review status: pending
Docs override: none
Source-owner resolution returned multiple candidates (szgupta, cephalonaut, danielpeng2), so no single engineering reviewer is requested under the docs policy.
Co-Authored-By: Oz oz-agent@warp.dev
Computer-use screenshots (2)
Local Bedrock policy
Cloud Bedrock policy
Unchanged provider-support evidence
Bedrock page, Model availability section
Overview page: supported providers list and comparison table with Models row (Anthropic (Claude) and OpenAI)