Repository navigation
Update winit to recover from X11 WM hints failures - #27
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Warp's winit pin to warpdotdev/winit#21. The new revision treats a failed X11
WM_HINTSsend as recoverable, preventing an abort when inactive bell handling encounters a dead connection.Linked Issue
Sentry WARP-CLIENT-BETA-STABLE-89S1.
ready-to-specorready-to-implement— Sentry incident, not a GitHub issueTesting
cargo test --lib --features x11 --no-default-featuresin winit (8 passed)cargo clippy --all-targets --features x11 --no-default-features -- -D warningsin winitcargo check -p warp --lockedcompiled the updated winit revision; the full Warp check was stopped before completion due to benchmark time constraints./script/formatI have manually tested my changes locally with
./script/run— reproducing a dead X11 connection requires terminating the display connectionAgent Mode
CHANGELOG-BUG-FIX: Prevent a terminal bell on Linux/X11 from crashing Warp after the display connection closes.
This PR was created by Warp (running Codex).