Skip to content

Prevent X11 attention request crashes - #28

Draft
warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
factory/recover-x11-attention-failure
Draft

warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
factory/recover-x11-attention-failure

Conversation

@warp-agent-staging

Copy link
Copy Markdown

Description

Pins winit to warpdotdev/winit#25 so Linux/X11 terminal bell requests no longer abort Warp when WM_HINTS cannot be sent over a dead connection. The dependency update is limited to the patched winit revision and its dpi workspace crate.

Linked Issue

Sentry WARP-CLIENT-BETA-STABLE-89S1

  • The linked issue is labeled ready-to-spec or ready-to-implement. — Sentry report, not a GitHub issue
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). — no visible UI change

Testing

cargo check -p warp and cargo clippy -p warp -- -D warnings pass with the patched revision. cargo metadata --locked --no-deps --format-version 1 confirms the lockfile resolves without updates. The winit change also passes cargo test --lib and cargo clippy --lib -- -D warnings.

  • I have manually tested my changes locally with ./script/run — reproducing the dead-connection race requires terminating the X11 connection during an attention request

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Fixed a crash when the terminal bell requests attention after an X11 connection closes.

This PR was created by Warp (running Codex).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants