Prevent X11 attention request crashes - #28
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pins winit to warpdotdev/winit#25 so Linux/X11 terminal bell requests no longer abort Warp when
WM_HINTScannot be sent over a dead connection. The dependency update is limited to the patched winit revision and itsdpiworkspace crate.Linked Issue
Sentry WARP-CLIENT-BETA-STABLE-89S1
ready-to-specorready-to-implement. — Sentry report, not a GitHub issueTesting
cargo check -p warpandcargo clippy -p warp -- -D warningspass with the patched revision.cargo metadata --locked --no-deps --format-version 1confirms the lockfile resolves without updates. The winit change also passescargo test --libandcargo clippy --lib -- -D warnings../script/run— reproducing the dead-connection race requires terminating the X11 connection during an attention requestAgent Mode
CHANGELOG-BUG-FIX: Fixed a crash when the terminal bell requests attention after an X11 connection closes.
This PR was created by Warp (running Codex).