Skip to content

Pin winit fix for X11 attention send crash - #53

Draft
warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
factory/x11-attention-winit-pin
Draft

warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
factory/x11-attention-winit-pin

Conversation

@warp-agent-staging

Copy link
Copy Markdown

Description

On Linux/X11, a disconnected display can make request_user_attention panic during terminal bell handling. Pin Warp to the winit fix so a failed hints send no longer aborts the client; successful sends still ignore the cookie.

Linked Issue

Sentry: WARP-CLIENT-BETA-STABLE-89S1. No GitHub issue was supplied.

  • The linked issue is labeled ready-to-spec or ready-to-implement — not a GitHub issue.
  • Where appropriate, screenshots or a short video of the implementation are included below — no UI presentation change.

Testing

  • The upstream Xvfb regression test passed after failing on the original panic; 8 winit library tests passed.
  • cargo metadata --locked resolved both winit and dpi from the new published commit.
  • cargo clippy --locked -p winit -- -D warnings passed using Warp's resolved dependency.
  • ./script/format completed.
  • I have manually tested my changes locally with ./script/run — the disconnected X11 path was exercised by the upstream regression test instead.

Agent Mode

  • Warp Agent Mode — created by Warp Factory, not Agent Mode.

CHANGELOG-BUG-FIX: Avoid crashing when the Linux X11 server disconnects during an attention request.

Plans:

@warp-agent-staging

Copy link
Copy Markdown
Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants