Pin winit fix for X11 attention send crash - #53
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Author
|
This PR was generated with Warp. Comment |
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
On Linux/X11, a disconnected display can make
request_user_attentionpanic during terminal bell handling. Pin Warp to the winit fix so a failed hints send no longer aborts the client; successful sends still ignore the cookie.Linked Issue
Sentry: WARP-CLIENT-BETA-STABLE-89S1. No GitHub issue was supplied.
ready-to-specorready-to-implement— not a GitHub issue.Testing
cargo metadata --lockedresolved bothwinitanddpifrom the new published commit.cargo clippy --locked -p winit -- -D warningspassed using Warp's resolved dependency../script/formatcompleted../script/run— the disconnected X11 path was exercised by the upstream regression test instead.Agent Mode
CHANGELOG-BUG-FIX: Avoid crashing when the Linux X11 server disconnects during an attention request.
Plans: