Skip to content

Update winit for recoverable X11 attention requests - #56

Draft
warp-agent-staging[bot] wants to merge 1 commit into
factory/benchmark-base-winit-wm-hintsfrom
factory/update-winit-x11-attention-fix-89s1
Draft

warp-agent-staging[bot] wants to merge 1 commit into
factory/benchmark-base-winit-wm-hintsfrom
factory/update-winit-x11-attention-fix-89s1

Conversation

@warp-agent-staging

Copy link
Copy Markdown

Description

Pin winit to warpdotdev/winit#32, where an X11 WM hints send failure no longer panics during request_user_attention. This prevents Warp from aborting if the X11 connection dies while the inactive terminal bell requests attention.

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement. — No GitHub issue is linked for this sandbox trial.
  • Where appropriate, screenshots or a short video of the implementation are included below. — Not applicable to this dependency-only update.

Testing

  • cargo check --manifest-path /workspace/warp/Cargo.toml --locked -p warp --lib — passed with winit at c5b7fe3c.
  • cargo clippy --manifest-path /workspace/warp/Cargo.toml --locked -p warp --all-targets --tests -- -D warnings — passed.
  • /workspace/warp/script/format --check — passed.
  • I have manually tested my changes locally with ./script/run. — Not run; reproducing the failure requires closing a live X11 connection beneath the window while attention is requested. The underlying winit X11 tests and Clippy pass.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Fixed a crash when the terminal bell requests attention after an X11 connection closes.

@warp-agent-staging

Copy link
Copy Markdown
Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation

@warp-agent-staging
warp-agent-staging Bot changed the base branch from master to factory/benchmark-base-winit-wm-hints September 25, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants