Update winit for recoverable X11 attention requests - #56
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Author
|
This PR was generated with Warp. Comment |
warp-agent-staging
Bot
changed the base branch from
master
to
factory/benchmark-base-winit-wm-hints
September 25, 2026 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Pin winit to warpdotdev/winit#32, where an X11 WM hints send failure no longer panics during
request_user_attention. This prevents Warp from aborting if the X11 connection dies while the inactive terminal bell requests attention.Linked Issue
ready-to-specorready-to-implement. — No GitHub issue is linked for this sandbox trial.Testing
cargo check --manifest-path /workspace/warp/Cargo.toml --locked -p warp --lib— passed with winit atc5b7fe3c.cargo clippy --manifest-path /workspace/warp/Cargo.toml --locked -p warp --all-targets --tests -- -D warnings— passed./workspace/warp/script/format --check— passed../script/run. — Not run; reproducing the failure requires closing a live X11 connection beneath the window while attention is requested. The underlying winit X11 tests and Clippy pass.Agent Mode
CHANGELOG-BUG-FIX: Fixed a crash when the terminal bell requests attention after an X11 connection closes.