Skip to content

Prevent X11 attention request crash - #57

Draft
warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
factory/pin-x11-attention-fix
Draft

warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
factory/pin-x11-attention-fix

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Description

Pin winit to the revision that treats an X11 WM-hints send failure as recoverable. This prevents inactive Warp windows from aborting when request_user_attention races with a closed X11 connection.

The corresponding winit change is warpdotdev/winit#33.

The branch remains based on the prepared benchmark commit. The benchmark remote's current master contains later dependency work and conflicts with this fixed-checkout patch, so those out-of-scope commits were not merged.

Linked Issue

No GitHub issue. This addresses Sentry event WARP-CLIENT-BETA-STABLE-89S1.

  • The linked issue is labeled ready-to-spec or ready-to-implement — no GitHub issue is linked.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes) — this failure path has no visual state to capture.

Testing

  • cargo check -p warp
  • cargo clippy --locked -p warp --all-targets --tests -- -D warnings
  • /workspace/warp/script/format
  • The pinned winit revision passed its X11-only test suite and clippy checks.

No new Warp tests were added because this PR only updates an immutable dependency revision. The regression behavior is implemented in winit and requires a deliberately dead X11 transport to reproduce manually.

  • I have manually tested my changes locally with ./script/run — the dead-connection race was not reproduced manually.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Prevented inactive Warp windows from crashing when their X11 connection closes.

@warp-agent-staging

Copy link
Copy Markdown
Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants