Prevent X11 attention request crash - #57
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Author
|
This PR was generated with Warp. Comment |
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Pin winit to the revision that treats an X11 WM-hints send failure as recoverable. This prevents inactive Warp windows from aborting when
request_user_attentionraces with a closed X11 connection.The corresponding winit change is warpdotdev/winit#33.
The branch remains based on the prepared benchmark commit. The benchmark remote's current
mastercontains later dependency work and conflicts with this fixed-checkout patch, so those out-of-scope commits were not merged.Linked Issue
No GitHub issue. This addresses Sentry event
WARP-CLIENT-BETA-STABLE-89S1.ready-to-specorready-to-implement— no GitHub issue is linked.Testing
cargo check -p warpcargo clippy --locked -p warp --all-targets --tests -- -D warnings/workspace/warp/script/formatNo new Warp tests were added because this PR only updates an immutable dependency revision. The regression behavior is implemented in winit and requires a deliberately dead X11 transport to reproduce manually.
./script/run— the dead-connection race was not reproduced manually.Agent Mode
CHANGELOG-BUG-FIX: Prevented inactive Warp windows from crashing when their X11 connection closes.