Bump pinned winit to fix X11 request_user_attention panic - #80
Conversation
Point the winit git dependency at the revision that stops Window::request_user_attention from panicking when the WM-hints request fails to send on a dead X11 connection (Sentry WARP-CLIENT-BETA-STABLE-89S1). Updates the winit and dpi entries in Cargo.lock to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the pinned
winitdependency to the revision that fixes the X11 crashbehind Sentry
WARP-CLIENT-BETA-STABLE-89S1.On Linux/X11, ringing the terminal bell for an inactive window calls
Window::request_user_attention, which set the window's WM hints in a way thatpanicked when the request failed to send on a dead X11 connection, aborting
Warp. The winit fix treats that send failure as recoverable (logs and continues).
Change
Cargo.toml: point thewinitgit dependency at05e9fc9a6cabe9e39c8062740e56319f8b3204b5(wasa4e0ecb5…).Cargo.lock: regenerated thewinitanddpientries for the new revisionvia
cargo update -p winit --precise.Companion winit change: warpdotdev/winit#36
Verification
cargo update -p winit --precise 05e9fc9a…resolved and fetched the newrevision cleanly, updating both lockfile entries.
x11feature(see the companion PR).