Update winit for QueryInterface failure handling - #16137
Open
warp-agent-staging[bot] wants to merge 1 commit into
Open
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
This PR was generated with Warp. Comment |
acarl005
marked this pull request as ready for review
September 24, 2026 00:24
acarl005
approved these changes
Sep 24, 2026
acarl005
enabled auto-merge (squash)
September 24, 2026 00:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Pins the workspace to the winit commit merged in warpdotdev/winit#27. The update brings the Windows file-drop
QueryInterfacefailure-path fix into the app, replacing an FFI panic with a warning andE_FAILfor WARP-CLIENT-BETA-STABLE-8C07.Linked Issue
warpdotdev/winit#27
WARP-CLIENT-BETA-STABLE-8C07
The linked issue is labeled
ready-to-specorready-to-implement— not applicable to this dependency integration.Where appropriate, screenshots or a short video of the implementation are included below — no UI changed.
Testing
Local dependency and build checks:
cargo metadata --locked --no-deps --format-version 1cargo check -p warpui --lockedcargo check -p warp --lib --lockedcargo clippy -p warpui --lib --locked -- -D warningscargo check -p warpui --target x86_64-pc-windows-gnu --lockedgit diff --checkNative Windows x86-64 MSVC verification at the PR head:
cargo metadata --locked --no-deps --format-version 1cargo check -p warpui --lockedcargo clippy -p warpui --lib --locked -- -D warningscargo check -p warp --lib --lockedwas blocked because the Windows runner does not haveprotoc.No new tests were added because this PR only advances a dependency pin. Both the Windows GNU cross-check and native MSVC
warpuicheck compile the fixed platform path through Warp; runtime behavior was not exercised../script/run— this dependency-only failure-path change has no directly exercisable UI flow.Agent Mode
CHANGELOG-BUG-FIX: Fixed a Windows crash when external software queried Warp's file-drop handler.