Skip to content

Update winit for QueryInterface failure handling - #16137

Open
warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
factory/update-winit-query-interface-fix
Open

warp-agent-staging[bot] wants to merge 1 commit into
masterfrom
factory/update-winit-query-interface-fix

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Description

Pins the workspace to the winit commit merged in warpdotdev/winit#27. The update brings the Windows file-drop QueryInterface failure-path fix into the app, replacing an FFI panic with a warning and E_FAIL for WARP-CLIENT-BETA-STABLE-8C07.

Linked Issue

  • warpdotdev/winit#27

  • WARP-CLIENT-BETA-STABLE-8C07

  • The linked issue is labeled ready-to-spec or ready-to-implement — not applicable to this dependency integration.

  • Where appropriate, screenshots or a short video of the implementation are included below — no UI changed.

Testing

Local dependency and build checks:

  • cargo metadata --locked --no-deps --format-version 1
  • cargo check -p warpui --locked
  • cargo check -p warp --lib --locked
  • cargo clippy -p warpui --lib --locked -- -D warnings
  • cargo check -p warpui --target x86_64-pc-windows-gnu --locked
  • git diff --check

Native Windows x86-64 MSVC verification at the PR head:

  • cargo metadata --locked --no-deps --format-version 1
  • cargo check -p warpui --locked
  • cargo clippy -p warpui --lib --locked -- -D warnings
  • cargo check -p warp --lib --locked was blocked because the Windows runner does not have protoc.

No new tests were added because this PR only advances a dependency pin. Both the Windows GNU cross-check and native MSVC warpui check compile the fixed platform path through Warp; runtime behavior was not exercised.

  • I have manually tested my changes locally with ./script/run — this dependency-only failure-path change has no directly exercisable UI flow.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Fixed a Windows crash when external software queried Warp's file-drop handler.

@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation

@acarl005
acarl005 marked this pull request as ready for review September 24, 2026 00:24
@acarl005 acarl005 self-assigned this Sep 24, 2026
@acarl005
acarl005 enabled auto-merge (squash) September 24, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant