Repository navigation
Keep slow dev renderer startup recoverable - #3536
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
👋 I've got this PR. GitHub updates from this session use the repository's bot account. |
|
Merged current This brings in the Go 1.26.8 module/CI alignment from #3537 and removes the retired TestDriver workflows via #3535. The previous failures were in Go-backed generation and the TestDriver build, so these updates address the likely cause and remove the obsolete job. The new CodeQL checks are running; there are no failures reported on the new head yet. CI success is not confirmed. I'll monitor for failures. The PR itself has not been merged. |
Deploying waveterm with
|
| Latest commit: |
985af01
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a990fb25.waveterm.pages.dev |
| Branch Preview URL: | https://cosmos-recover-dev-renderer.waveterm.pages.dev |
Summary
The five-second development timeout rejected
initializeTabbefore it could sendwave-init. A late rendererreadyIPC still resolved the original handshake, but startup had already been abandoned, leaving a hidden/blank renderer.initPromiseandwaveReadyPromise; reveal the window/DevTools and continue waiting instead of treating slowness as fatal.A larger fixed timeout would only move the race. A live renderer that never signals readiness still remains pending with diagnostics available; automatic crash recovery and production timeouts are outside this fix.
The final diff is one production-source file, +39/-20 lines. The oversized 212-line mocked Electron test harness was removed following review; it was disproportionate to this change. The main-process fix is byte-for-byte unchanged from the version verified in Electron.
Validation
task electron:linuxquickdev, ascodespace, with isolated app data and sandbox intact: naturally crossed the diagnostic threshold at 19.923s, sent normalwave-initat 20.128s, and completed thewave-readywait at 20.332s. Vite was ready at 13.840s; mapped-window timing was not treated as app readiness.printf 'WAVE_RUNTIME_OK\n', producing the marker and returning a prompt. No runtime delay injection was needed.task check:ts: 17 existing errors in three preview fixture files. A read-only compiler comparison against the exact unchanged main-process source produced identical diagnostics; the fix adds none.git diff --check: passed, including after removal of the test harness. Confirmed the runtime-verified main-process source did not change in that follow-up.Original investigation, tradeoffs, checks, and timing report · Rendered app screenshot · Terminal verification screenshot
Cosmos evidence links require VFS permissions. The linked report is a historical record of the original local-validation stage, including the test harness subsequently removed; this PR description reflects the final scope. Raw runtime logs are not uploaded. The upstream first-load delay remains unproven. Other operating systems, production packaging, and the full test suite were not run.