feat(dashboard): make v2 the default + add setup/assets mix aliases#8
Merged
feat(dashboard): make v2 the default + add setup/assets mix aliases#8
Conversation
Strip the legacy React shell and shadcn copy-paste UI in favor of HEEx LiveViews plus one ReactFlow island for the workflow graph (mounted via phx-hook). Remaining JS lives in assets/src/react/, assets/src/hooks/, and a new entry in assets/src/main.ts. All other UI moves to lib/durable_dashboard/components/* HEEx primitives codified in DESIGN.md. Also includes: - New durable_dashboard/README.md - "Dashboard" section in durable/README.md describing the macro install - Workspace .gitignore entry for /tmp/
…blish mix setup - deps.get + pnpm install (assets.setup) mix assets.build - vite build into priv/static hex.build/publish runs assets.build first so the tarball ships fresh, production-built JS/CSS to consumers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes that follow up on PR #7:
cfac43d(formerlye1f6838) — the dashboard rewrite that collapses to LiveView-first with a single React island. This was developed onfeat/dashboardbut the PR merge stopped atf78c665, leaving the legacy non-v2 React shell and the oldassets/src/v2/folder still onmain. After this PR, v2 is the default: thev2/directory is gone, files live atassets/src/react/,assets/src/hooks/, andassets/src/main.ts.b0c8aa9):mix setup—deps.get+cmd --cd assets pnpm installmix assets.setup—pnpm installonlymix assets.build—pnpm build(vite production build intopriv/static/durable_dashboard/)mix hex.buildandmix hex.publish— both runassets.buildfirst so the Hex tarball ships fresh, production-built JS/CSS to consumers.Test plan
cd durable_dashboard && mix setup(deps + pnpm install both run)cd durable_dashboard && mix assets.build(vite emits app.css, app.js, flow_graph-.js, vendor-xyflow-.js)cd durable_dashboard && MIX_ENV=test mix compile --warnings-as-errorscd durable_dashboard && mix test(73 tests pass)find durable_dashboard -type d -name '*v2*'returns nothinggit grep "_v2\|/v2/" durable_dashboard/{lib,test,assets/src}returns nothing