fix: unblock pnpm test after the KaTeX math change - #2
Merged
Merged
Conversation
…e live math assertions
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1. On
core,pnpm testfails before Vitest starts, and one new test is flaky under the full suite.scripts/vercel-sparse-non-deploy-paths.mjs: feat(web): render $…$ and $$…$$ math with KaTeX #1 added the top-levelvitest.config.ts, which the sparse-path check rejects (Top-level path 'vitest.config.ts' is neither in .github/vercel-sparse-paths.txt nor a known non-deploy path.). It only configures tests, so it is classified as non-deploy.apps/web/src/components/live-markdown/math.test.ts: the first CodeMirror parse runs on a time budget, so under full-suite load the fenced code block at the end of the fixture could still be unparsed and its$$y$$was drawn as math (expected [ true, true ] to deeply equal [ true ]). The test now finishes the parse and lets the decorations recompute before asserting, which is what the editor does once its parser catches up. Editor behaviour is unchanged.Verification:
pnpm testtwice in a row, 197 files / 1402 tests passing each time;pnpm lintclean;tsc --noEmitinapps/webpasses.