Skip to content

fix: unblock pnpm test after the KaTeX math change - #2

Merged
wayne930242 merged 1 commit into
corefrom
fix/sparse-paths-vitest-config
Sep 27, 2026
Merged

wayne930242 merged 1 commit into
corefrom
fix/sparse-paths-vitest-config

Conversation

@wayne930242

Copy link
Copy Markdown
Owner

Follow-up to #1. On core, pnpm test fails before Vitest starts, and one new test is flaky under the full suite.

  • scripts/vercel-sparse-non-deploy-paths.mjs: feat(web): render $…$ and $$…$$ math with KaTeX #1 added the top-level vitest.config.ts, which the sparse-path check rejects (Top-level path 'vitest.config.ts' is neither in .github/vercel-sparse-paths.txt nor a known non-deploy path.). It only configures tests, so it is classified as non-deploy.
  • apps/web/src/components/live-markdown/math.test.ts: the first CodeMirror parse runs on a time budget, so under full-suite load the fenced code block at the end of the fixture could still be unparsed and its $$y$$ was drawn as math (expected [ true, true ] to deeply equal [ true ]). The test now finishes the parse and lets the decorations recompute before asserting, which is what the editor does once its parser catches up. Editor behaviour is unchanged.

Verification: pnpm test twice in a row, 197 files / 1402 tests passing each time; pnpm lint clean; tsc --noEmit in apps/web passes.

@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
my-gh-core Ignored Ignored Sep 27, 2026 8:18am UTC
mygitnotes-gitlab-test Ignored Ignored Preview Sep 27, 2026 8:18am UTC

Request Review

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@wayne930242
wayne930242 merged commit 866a084 into core Sep 27, 2026
5 checks passed
@wayne930242
wayne930242 deleted the fix/sparse-paths-vitest-config branch September 27, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant