Skip to content

Add upcoming terms of use page#1130

Open
rosalieper wants to merge 18 commits into
mainfrom
T420575
Open

Add upcoming terms of use page#1130
rosalieper wants to merge 18 commits into
mainfrom
T420575

Conversation

@rosalieper
Copy link
Copy Markdown
Contributor

@rosalieper rosalieper commented Jun 2, 2026

Bug: T420575

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Deployment previews on netlify for branch refs/pull/1130/merge will be at the following locations (when build is done):

Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
Comment thread src/components/Pages/TermsOfUseUpcoming.vue Outdated
Comment thread src/components/Pages/TermsOfUse/Upcoming.vue Outdated
@deer-wmde
Copy link
Copy Markdown
Contributor

The footnote links I added need the change from here to work #1131

@rosalieper rosalieper marked this pull request as ready for review June 5, 2026 08:53
@rosalieper
Copy link
Copy Markdown
Contributor Author

The browser test failure is unrelated to this change.

@rosalieper rosalieper changed the title WIP: Add upcoming terms of use page Add upcoming terms of use page Jun 5, 2026
color="info"
>
<div class="text-h6 mb-3 blue--text text--darken-2">
What changed from <a class=""><u>previous version</u></a></div>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could already let this point to the current terms of use

Suggested change
What changed from <a class=""><u>previous version</u></a></div>
What changed from <router-link to="/terms-of-use">previous version</router-link></div>

second thought/note: I think there is some ongoing discussion about how we want the URLs to the different versions look like. My latest idea was to maybe make use of vue-router aliases: https://v3.router.vuejs.org/guide/essentials/redirect-and-alias.html - but this probably needs further discussion among engineers

text
color="info"
>
<div class="text-h6 mb-3 blue--text text--darken-2">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems currently the color applies only to the heading here, we separate the styling here a bit by wrapping the header in a p element or something with the text-h6 mb-3 classes, while wrapping the whole box into the div with the blue--text text--darken-2 classes

Also in figma darken-4 gets used:
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants