Repository navigation
fix(rust): pass the configured llvm tools to rust_test; document coverage - #45
Merged
Merged
Conversation
Document report location, format and contents, and add a CI coverage smoke test. Refs #41 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Refs #41 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
plz prints the coverage table on stderr, so tee saw nothing. Also show test output to diagnose a 0% result seen on the runner. Refs #41 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Diagnose a 0% result seen only on the runner. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Report the resolved path and version in the coverage error to diagnose a runner-only failure; print the host rustc in the smoke step. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
CONFIG.get("RUST.X") does not read plugin config, so LlvmProfdataTool, LlvmCovTool and Coverage were ignored: test_tools held only the runner and llvm-profdata was found on the host. On a runner with an older host LLVM the merge failed ("unsupported instrumentation profile format version") and coverage was 0%. Read the keys as CONFIG.RUST.<KEY>.
Refs #41
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
walterjgsp
changed the title
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust_testreadLlvmProfdataTool,LlvmCovToolandCoveragewithCONFIG.get("RUST.X"), which does not see plugin config.test_toolsheld only the runner, sollvm-profdatacame from the host. On the GitHub runner that was LLVM 16 andplz coverreportedlib.rs 0/3(unsupported instrumentation profile format version); locally it only worked because the host LLVM was new. Now read asCONFIG.RUST.<KEY>.llvm-profdatathat failed.No datawithout[cover] fileextension = .rs.[Unreleased]; no release is planned.Test plan
plz cover //test/rust/lib:lib_test:lib.rs 3/3;plz test //tools/... //test/...passeslib.rs 3/3 linesRefs #41
🤖 Generated with Claude Code