Repository navigation
ci(swift): assert coverage with lcovcheck instead of grep - #72
Merged
Merged
Conversation
The smoke steps grepped Please's console coverage table and the raw .lcov text. Use lcovcheck: Please's coverage.json for the per-file coverage, and the shared lcov parser for line statuses and function hits of the exported report. Item 4 of #66. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 4 of #66, for the swift rules. The coverage smoke steps used
grep -Eon Please's console table (a human format that differs between Please versions and is not printed the same on cache hits) and on the raw.lcovtext.lcovcheck -coverage-json plz-out/log/coverage.json -covered <file>(structured, no console parsing)..lcovexport:lcovcheck -lcov ... -path ... -line N=status -function NAME=hit|missed|Non the shared parser, so a line is asserted to be covered, uncovered or partial instead of matching aBRDArecord by text.The assertions are the same facts as before (and a few more: the uncovered line), and I ran the built binary against this fixture's real output, and against a real
coverage.json, before writing them.lcovcheckitself comes frommain(#68), already synced here.🤖 Generated with Claude Code