Repository navigation
refactor(wit): discover worlds and package with the AST parser - #74
Merged
Merged
Conversation
DiscoverWorlds and DiscoverPackage scanned lines with regexes that missed versioned packages and tripped on comments. They now use the shared lenient AST parser from tools/common/wit/ast, and the branch's copy of the parser is removed. Item 3 of #66. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 3 of #66 (wit side). Depends on the shared parser from #73, already synced here.
DiscoverWorlds/DiscoverPackagescanned lines withworldRegex/packageRegex. The package regex did not matchpackage wasi:cli@0.2.0;at all (returned empty), and a line scan can't tell a comment or a second declaration on the same line. They now useast.ParseFileLenient(skipsuse/variant/flags, which discovery doesn't need).tools/please_wit/astis removed; imports, BUILD deps and docs point totools/common/wit/ast.plz test //tools/please_wit/... //tools/common/wit/...: 325 passed.🤖 Generated with Claude Code