Repository navigation
fix(common): parse static resource functions as the WIT spec writes them - #75
Merged
Merged
Conversation
The parser only accepted the non-standard 'static name: func()'. WIT spells it 'name: static func()', which failed with: expected 'func', got "static". Both spellings now parse, and Function.Static marks them. Found while moving the Kotlin wasm WIT parsing onto the AST (item 3 of #66). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while moving the Kotlin wasm rules onto the shared parser (#66, item 3).
The parser accepted
static reset-all: func();, which is not WIT. The spec writesreset-all: static func();, and that failed withexpected 'func', got "static". The existing tests only used the non-standard form.name: static func(...)now parses and lands inResource.Static.Function.Staticmarks both.31 tests (1 new, covering both spellings in one resource).
🤖 Generated with Claude Code