Skip to content

refactor(create-rslib): use Vue Test Utils in templates - #1834

Merged
chenjiahan merged 3 commits into
mainfrom
chenjiahan/refactor-create-rslib-vue-test-utils
Aug 9, 2026
Merged

refactor(create-rslib): use Vue Test Utils in templates#1834
chenjiahan merged 3 commits into
mainfrom
chenjiahan/refactor-create-rslib-vue-test-utils

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

  • Replace @testing-library/vue with the official @vue/test-utils package in the Vue JavaScript and TypeScript templates.
  • Update the default component tests to mount and unmount Vue wrappers directly.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI lite review requested due to automatic review settings August 9, 2026 11:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the create-rslib Vue (JS/TS) templates to use the official @vue/test-utils package for component testing instead of @testing-library/vue, aligning the generated starter tests with Vue’s recommended tooling.

Changes:

  • Switched template component tests from render/screen (Testing Library) to mount (Vue Test Utils).
  • Updated Vue template dependencies to remove @testing-library/vue.
  • Adjusted template package metadata ordering (moved publishConfig placement).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/create-rslib/template-vue-ts/tests/index.test.ts Migrates the Vue TS template test to Vue Test Utils mounting.
packages/create-rslib/template-vue-ts/package.json Removes @testing-library/vue from devDependencies and reorders publishConfig.
packages/create-rslib/template-vue-js/tests/index.test.js Migrates the Vue JS template test to Vue Test Utils mounting.
packages/create-rslib/template-vue-js/package.json Removes @testing-library/vue from devDependencies and reorders publishConfig.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/create-rslib/template-vue-js/tests/index.test.js
Comment thread packages/create-rslib/template-vue-ts/tests/index.test.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24d43c33dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/create-rslib/template-vue-js/tests/index.test.js
@chenjiahan
chenjiahan merged commit 92c0e20 into main Aug 9, 2026
11 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/refactor-create-rslib-vue-test-utils branch August 9, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants