refactor(pack): extract helper functions from encode.rs to improve testability by p05-HY · Pull Request #136 · web3infra-foundation/git-internal

p05-HY · 2026-05-28T02:56:42Z

Split complex functions in PackEncoder into smaller, testable units
while preserving all existing pack encoding semantics.

Changes:

Add TypedEntryBuckets struct to represent classified object buckets
Extract classify_entries_by_type() from inner_encode() for object classification
Extract sort_entry_buckets() from inner_encode() for bucket sorting
Extract score_delta_candidate() from try_as_offset_delta() for delta base evaluation

New unit tests (5):

test_classify_entries_by_type_groups_supported_objects
test_classify_entries_by_type_rejects_delta_objects
test_sort_entry_buckets_uses_magic_sort_for_each_type
test_score_delta_candidate_rejects_unsuitable_bases
test_score_delta_candidate_accepts_similar_content

Testing:

218 unit tests, 4 integration tests, 1 doctest all pass
cargo clippy -D warnings pass
cargo fmt --check pass

Behavior:

No behavioral changes to pack encoding output.

Signed-off-by: Quanyi Ma <eli@patch.sh>

init codebase

Signed-off-by: Neon <neonkk@qq.com>

fix: mercury compilation

Signed-off-by: Eli Ma <eli@patch.sh>

Fix tests case

…tion#4) Signed-off-by: Quanyi Ma <eli@patch.sh>

* Add r2cn issue template Signed-off-by: Quanyi Ma <eli@patch.sh> * Add documentations and update issue templates Signed-off-by: Quanyi Ma <eli@patch.sh> --------- Signed-off-by: Quanyi Ma <eli@patch.sh>

Signed-off-by: Quanyi Ma <eli@patch.sh>

…ndation#8) Resolves web3infra-foundation#6 Signed-off-by: allure <1550220889@qq.com>

add .devcontainer

Signed-off-by: Quanyi Ma <eli@patch.sh>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Add dependabot config and update issue templates

Signed-off-by: allure <1550220889@qq.com>

…otocal feat: Abstract HTTP and SSH protocal from mega to git-internal

Signed-off-by: allure <1550220889@qq.com>

* Add copilot-instructions.md for GitHub copilot Signed-off-by: Eli Ma <eli@patch.sh> * Update .github/copilot-instructions.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/copilot-instructions.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Eli Ma <eli@patch.sh> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Signed-off-by: Quanyi Ma <eli@patch.sh>

Update git protocol doc and reformat core.rs

Signed-off-by: Eli Ma <eli@patch.sh>

* add ai_obj and update buck Signed-off-by: jackie <jackieismpc@gmail.com> * refactor project and fix some bugs Signed-off-by: jackie <jackieismpc@gmail.com> * restore hash Signed-off-by: jackie <jackieismpc@gmail.com> * update checksum Signed-off-by: jackie <jackieismpc@gmail.com> * update base object Signed-off-by: jackie <jackieismpc@gmail.com> * update process object Signed-off-by: jackie <jackieismpc@gmail.com> * update doc Signed-off-by: jackie <jackieismpc@gmail.com> * update seal Signed-off-by: jackie <jackieismpc@gmail.com> * refactor base Signed-off-by: jackie <jackieismpc@gmail.com> * update ai_hash Signed-off-by: jackie <jackieismpc@gmail.com> * splite objects Signed-off-by: jackie <jackieismpc@gmail.com> * update docs Signed-off-by: jackie <jackieismpc@gmail.com> * rename objects Signed-off-by: jackie <jackieismpc@gmail.com> --------- Signed-off-by: jackie <jackieismpc@gmail.com>

* Update objects of agent flow Signed-off-by: Quanyi Ma <eli@patch.sh> * Fix zstdelta test Signed-off-by: Eli Ma <eli@patch.sh> * Fix copilot warnings Signed-off-by: Eli Ma <eli@patch.sh> * Update claude review action Signed-off-by: Eli Ma <eli@patch.sh> * Update claude review action Signed-off-by: Eli Ma <eli@patch.sh> --------- Signed-off-by: Quanyi Ma <eli@patch.sh> Signed-off-by: Eli Ma <eli@patch.sh>

Signed-off-by: Quanyi Ma <eli@patch.sh>

…y enforcement (web3infra-foundation#99) * Apply AI object and context fixes Signed-off-by: Quanyi Ma <eli@patch.sh> * ai-objects: apply review feedback and tighten invariants Signed-off-by: Quanyi Ma <eli@patch.sh> * Fix fmt Signed-off-by: Quanyi Ma <eli@patch.sh> * Fix critical issues from PR web3infra-foundation#98 review - Fix Header::seal() checksum integrity bug: remove updated_at mutation after checksum computation so the checksum matches the final object state - Fix Intent error variants: use InvalidIntentObject instead of generic InvalidObjectInfo in from_bytes() and to_data() - Fix semantic versioning: bump to 0.6.0 (not 0.5.1) since PR web3infra-foundation#98 added new public types, enum variants, and trait methods Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Quanyi Ma <eli@patch.sh> * Reject AI object types in pack encode/decode paths AI extension types (ContextSnapshot, Decision, etc.) use u8 IDs >= 8 which cannot fit in the 3-bit pack header type field (values 1-7). Previously, the decode path silently returned Ok(None) for these types (dead code since from_pack_type_u8 already rejects them), and the parallel_encode path lacked an early check, letting AI objects fail deep in encode_one_object with a generic error. - Add ObjectType::is_ai_object() helper for classifying AI extensions - Replace silent Ok(None) in decode with explicit InvalidPackFile error - Add early AI type rejection in parallel_encode before batching Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Quanyi Ma <eli@patch.sh> * ai-objects: update project metadata and documentation Update Cargo.toml description/keywords/categories, README.md overview and AI Object Model section, and CLAUDE.md with comprehensive AI object model guidance including end-to-end flow, file mapping, key patterns, and documentation links. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Quanyi Ma <eli@patch.sh> * Fix backward compatibility for PlanStep.statuses and Header.updated_at - PlanStep.statuses: add #[serde(default)] with a Pending-entry default so legacy plans with the old single `status` field can still deserialize. - Header.updated_at: replace Utc::now() default with a custom Deserialize impl that falls back to created_at, avoiding nondeterministic metadata when loading legacy objects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Quanyi Ma <eli@patch.sh> * Address code review: fix panics, frame stability, seal semantics, is_base - ObjectType::to_bytes() returns Option instead of panicking on delta types; callers updated (pack/utils.rs, zlib/inflate.rs) - Intent::status() and PlanStep::status() return Option instead of panicking via expect() on potentially empty statuses Vec - ObjectType::is_base() returns false for AI types (they cannot participate in pack delta window selection) - ContextFrame gains stable frame_id assigned by ContextPipeline's monotonic counter; PlanStep iframes/oframes changed from Vec<u32> indices to Vec<u64> frame IDs that survive eviction - Header::seal() now updates updated_at timestamp - Updated docs/ai.md with frame ID semantics and usage examples Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Quanyi Ma <eli@patch.sh> --------- Signed-off-by: Quanyi Ma <eli@patch.sh> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Signed-off-by: Quanyi Ma <eli@patch.sh>

Signed-off-by: Eli Ma <eli@patch.sh>

Signed-off-by: jl.jiang <jiangjl9807@gmail.com>

Signed-off-by: Quanyi Ma <eli@patch.sh>

…#108) * chore: bump chrono to 0.4.44 and uuid to 1.21.0 Signed-off-by: Steven <fyoylf@gmail.com> * chore: remove claude-review workflow Signed-off-by: Steven <fyoylf@gmail.com> --------- Signed-off-by: Steven <fyoylf@gmail.com>

* chore: align intent pipeline lifecycle and comments Signed-off-by: Quanyi Ma <eli@patch.sh> * docs: add agent and protocol documentation set Signed-off-by: Quanyi Ma <eli@patch.sh> * refactor: replace plan fwindow with iframes and update docs Signed-off-by: Quanyi Ma <eli@patch.sh> * docs: expand agent object documentation Signed-off-by: Quanyi Ma <eli@patch.sh> * feat: add agent event objects Signed-off-by: Quanyi Ma <eli@patch.sh> * refactor: address review feedback on object model - Remove clone-on-copy in intent_event.rs - Delegate ObjectTrait::object_hash to ObjectHash::from_type_and_data - Add ObjectType round-trip tests for variant coverage - Include mismatched intent IDs in Plan error message - Replace ParentLike trait with direct &[Uuid] parameter Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Quanyi Ma <eli@patch.sh> * Document and refine intent workflow model Signed-off-by: Quanyi Ma <eli@patch.sh> * ci: add crates.io publish workflow on tag push Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Quanyi Ma <eli@patch.sh> * ci: add least-privilege permissions to publish workflow Signed-off-by: Quanyi Ma <eli@patch.sh> --------- Signed-off-by: Quanyi Ma <eli@patch.sh> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

* Upgrade some crates Signed-off-by: Eli Ma <eli@patch.sh> * Upgrade commit Signed-off-by: Eli Ma <eli@patch.sh> --------- Signed-off-by: Eli Ma <eli@patch.sh>

* Replace bincode with rkyv 0.8.15 Signed-off-by: Quanyi Ma <eli@patch.sh> * Declare rkyv bytecheck feature explicitly Signed-off-by: Quanyi Ma <eli@patch.sh> * Harden pack cache spill format handling Signed-off-by: Quanyi Ma <eli@patch.sh> * Fix rustfmt formatting in cache spill code Signed-off-by: Quanyi Ma <eli@patch.sh> * Harden atomic cache spill writes Signed-off-by: Quanyi Ma <eli@patch.sh> * Refine pack cache spill review fixes Signed-off-by: Quanyi Ma <eli@patch.sh> * Avoid clobbering existing pack cache files Signed-off-by: Quanyi Ma <eli@patch.sh> * Skip redundant pack cache re-encoding Signed-off-by: Quanyi Ma <eli@patch.sh> * Align pack cache spill save and tests Signed-off-by: Quanyi Ma <eli@patch.sh> --------- Signed-off-by: Quanyi Ma <eli@patch.sh>

…ra-foundation#118) Bumps the cargo group with 1 update in the / directory: [time](https://github.com/time-rs/time). Updates `time` from 0.3.44 to 0.3.47 - [Release notes](https://github.com/time-rs/time/releases) - [Changelog](https://github.com/time-rs/time/blob/main/CHANGELOG.md) - [Commits](time-rs/time@v0.3.44...v0.3.47) --- updated-dependencies: - dependency-name: time dependency-version: 0.3.47 dependency-type: indirect dependency-group: cargo ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Quanyi Ma <eli@patch.sh>

…stability Split complex functions in PackEncoder into smaller, testable units while preserving all existing pack encoding semantics. Changes: 1. Add TypedEntryBuckets struct to represent classified object buckets 2. Extract classify_entries_by_type() from inner_encode() for object classification 3. Extract sort_entry_buckets() from inner_encode() for bucket sorting 4. Extract score_delta_candidate() from try_as_offset_delta() for delta base evaluation New unit tests (5): - test_classify_entries_by_type_groups_supported_objects - test_classify_entries_by_type_rejects_delta_objects - test_sort_entry_buckets_uses_magic_sort_for_each_type - test_score_delta_candidate_rejects_unsuitable_bases - test_score_delta_candidate_accepts_similar_content All existing tests pass (218 unit tests, 4 integration tests, 1 doctest). cargo clippy -D warnings and cargo fmt --check pass. No behavioral changes to pack encoding output.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe7d454417

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-28T03:00:11Z

+        if name.starts_with(prefix) && name.ends_with(".pack") {
+            return entry.path();


Ensure pack fixtures are available without LFS smudge

In clones where Git LFS has not been pulled, find_pack now returns the checked-in LFS pointer file because the previous download fallback was removed and the new fixtures are LFS-managed. The decoder then reads version ... instead of the PACK magic and these integration tests fail before exercising the pack code; please either retain a fetch/fallback path or validate/fetch the LFS object before returning the path.

Useful? React with 👍 / 👎.

- Use sort_by_key instead of sort_by in pack_index.rs - Collapse nested if into match guard in pack.rs

p05-HY · 2026-05-28T06:43:24Z

@genedna CI is green ✅. Please take a look when you have time. Thanks!

p05-HY · 2026-05-28T11:41:10Z

@genedna Sorry for the close, accidentally clicked. PR is ready for review. Thanks!

p05-HY · 2026-06-01T06:57:42Z

@genedna CI is green ✅. Please take a look when you have time. Thanks!

p05-HY · 2026-06-15T02:31:06Z

@genedna ，Hi maintainers, just a gentle ping on this PR. All CI checks have passed. Is there anything else needed from my side? Thanks!

genedna and others added 30 commits September 25, 2025 17:39

Initial commit

d370a93

Signed-off-by: Quanyi Ma <eli@patch.sh>

init codebase

dd93c68

Merge pull request web3infra-foundation#1 from yyk808/main

61ea185

init codebase

fix: mercury compilation

d727c76

Signed-off-by: Neon <neonkk@qq.com>

chore: set MIT license

afc1c18

Signed-off-by: Neon <neonkk@qq.com>

chore: specify dependencies' version

905fa44

Signed-off-by: Neon <neonkk@qq.com>

fix publish requirements

1271d0b

Signed-off-by: Neon <neonkk@qq.com>

fix: change name to git-internal

270320c

Signed-off-by: Neon <neonkk@qq.com>

Merge pull request web3infra-foundation#2 from yyk808/main

d7213a8

fix: mercury compilation

Fix tests case

802c32c

Signed-off-by: Eli Ma <eli@patch.sh>

Fix with Copilot suggestions

70470dd

Signed-off-by: Eli Ma <eli@patch.sh>

Merge pull request web3infra-foundation#3 from genedna/main

a2a4292

Fix tests case

Fix all test cases, add files for test cases in LFS (web3infra-founda…

aa8ebb3

…tion#4) Signed-off-by: Quanyi Ma <eli@patch.sh>

Add r2cn issue template (web3infra-foundation#5)

6465d0c

* Add r2cn issue template Signed-off-by: Quanyi Ma <eli@patch.sh> * Add documentations and update issue templates Signed-off-by: Quanyi Ma <eli@patch.sh> --------- Signed-off-by: Quanyi Ma <eli@patch.sh>

add .devcontainer

d1877e0

Signed-off-by: Quanyi Ma <eli@patch.sh>

Update name of devcontainer

e30558a

Signed-off-by: Quanyi Ma <eli@patch.sh>

feat: Implement Git Note object parsing and generation (web3infra-fou…

1673bc5

…ndation#8) Resolves web3infra-foundation#6 Signed-off-by: allure <1550220889@qq.com>

Merge pull request web3infra-foundation#9 from genedna/main

a4128b4

add .devcontainer

Add dependabot config and update issue templates

fbab56c

Signed-off-by: Quanyi Ma <eli@patch.sh>

Apply suggestion from @Copilot

e3ebc74

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/errors.rs

f522496

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge pull request web3infra-foundation#11 from genedna/main

5a82c5d

Add dependabot config and update issue templates

feat: Abstract HTTP and SSH protocal from mega to git-internal

e181cf7

Signed-off-by: allure <1550220889@qq.com>

refactor: Address review feedback for protocol

ee6334c

Signed-off-by: allure <1550220889@qq.com>

fix: fix error about HTTP and SSH abstract

9337d5b

Signed-off-by: allure <1550220889@qq.com>

Merge pull request web3infra-foundation#12 from AllureCurtain/feat/pr…

88e4813

…otocal feat: Abstract HTTP and SSH protocal from mega to git-internal

docs: Update GIT_PROTOCOL_GUIDE.md (web3infra-foundation#15)

772b4b3

Signed-off-by: allure <1550220889@qq.com>

Update git protocol doc and reformat core.rs

8c95a45

Signed-off-by: Quanyi Ma <eli@patch.sh>

Merge pull request web3infra-foundation#17 from genedna/main

8af9943

Update git protocol doc and reformat core.rs

genedna and others added 21 commits January 21, 2026 20:45

Upgrade the buck2 support with newest buckal (web3infra-foundation#83)

096151b

Signed-off-by: Eli Ma <eli@patch.sh>

Bump version to 0.5.0 (web3infra-foundation#92)

500843b

Signed-off-by: Quanyi Ma <eli@patch.sh>

Apply AI object and context fixes (web3infra-foundation#98)

19f962f

Fix Claude Review error (web3infra-foundation#100)

de0253c

Signed-off-by: Quanyi Ma <eli@patch.sh>

Upgrade crates (web3infra-foundation#101)

0caa69b

Signed-off-by: Eli Ma <eli@patch.sh>

chore: bump rand to 0.10.0 (web3infra-foundation#103)

665ed69

Signed-off-by: jl.jiang <jiangjl9807@gmail.com>

Bump to 0.6.1 (web3infra-foundation#105)

755a5c9

Signed-off-by: Quanyi Ma <eli@patch.sh>

Bump to 0.6.1 (web3infra-foundation#106)

cf77780

Signed-off-by: Quanyi Ma <eli@patch.sh>

Upgrade some crates (web3infra-foundation#116)

b350e04

* Upgrade some crates Signed-off-by: Eli Ma <eli@patch.sh> * Upgrade commit Signed-off-by: Eli Ma <eli@patch.sh> --------- Signed-off-by: Eli Ma <eli@patch.sh>

Bump to 0.7.1 (web3infra-foundation#119)

6e92e2e

Signed-off-by: Quanyi Ma <eli@patch.sh>

Bump to 0.7.2 (web3infra-foundation#120)

f62bd29

Signed-off-by: Quanyi Ma <eli@patch.sh>

bump to 0.7.3 (web3infra-foundation#121)

5747f2c

Signed-off-by: Quanyi Ma <eli@patch.sh>

Merge branch 'main' into fix/split-Encode

fe7d454

Copilot AI review requested due to automatic review settings May 28, 2026 02:56

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

fix: resolve clippy warnings

61d0a71

- Use sort_by_key instead of sort_by in pack_index.rs - Collapse nested if into match guard in pack.rs

p05-HY closed this May 28, 2026

p05-HY reopened this May 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(pack): extract helper functions from encode.rs to improve testability#136

refactor(pack): extract helper functions from encode.rs to improve testability#136
p05-HY wants to merge 105 commits into
web3infra-foundation:mainfrom
p05-HY:fix/split-Encode

p05-HY commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Uh oh!

p05-HY commented May 28, 2026

Uh oh!

p05-HY commented May 28, 2026

Uh oh!

p05-HY commented Jun 1, 2026

Uh oh!

p05-HY commented Jun 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

		if name.starts_with(prefix) && name.ends_with(".pack") {
		return entry.path();

Conversation

p05-HY commented May 28, 2026

Changes:

New unit tests (5):

Testing:

Behavior:

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

p05-HY commented May 28, 2026

Uh oh!

p05-HY commented May 28, 2026

Uh oh!

p05-HY commented Jun 1, 2026

Uh oh!

p05-HY commented Jun 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants