Repository navigation
fix: recover subscription discovery after transient empty results - #11
Open
Krishna-Chaitanya4 wants to merge 2 commits into
Open
Krishna-Chaitanya4 wants to merge 2 commits into
Krishna-Chaitanya4 wants to merge 2 commits into
Conversation
Cache successful empty subscription lists for at most one minute while preserving shorter positive TTLs and normal non-empty caching. Avoid the cached-list wrapper overwriting the capped expiration. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Retain a defensive copy of configured subscription IDs instead of a permanent discovery snapshot. Preserve eager discovery and error timing, and refresh filtered results through the existing service-discovery cache. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Krishna-Chaitanya4
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Subscription discovery could remain empty after access became available: empty results were cached for an hour, and configured subscription iterators retained their initial list indefinitely.
Validation
Full Go tests and targeted vet passed. Regression tests fail before the iterator fix and pass afterward.
An isolated Kubernetes Job compared baseline and fixed code against mocked ARM responses. After 61 seconds, the baseline remained empty; the fixed client and configured iterator recovered with one additional request. Normal startup, persistently empty results, request bounds, and authorization errors also passed. Test resources were removed; existing workloads were unchanged.
Scope: Kubernetes-hosted library tests only. Live Azure RBAC propagation and a patched exporter deployment have not been validated.