Skip to content

feat(api-workflows): tests - #6041

Open
brunozoric wants to merge 48 commits into
bruno/feat/workflows-umbrellafrom
bruno/feat/workflows-api-workflows-tests
Open

brunozoric wants to merge 48 commits into
bruno/feat/workflows-umbrellafrom
bruno/feat/workflows-api-workflows-tests

Conversation

@brunozoric

@brunozoric brunozoric commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Tests for the workflows engine. Also allowlists one made-up test value in .gitleaks.toml.

Part of the workflows split (230 files). Merges into bruno/feat/workflows-umbrella; builds only together with the other parts.

🤖 Generated with Claude Code

brunozoric and others added 2 commits October 21, 2026 09:09
… gitleaks

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Split from bruno/refactor/workflows-flow for review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 503fd526-3166-4052-996d-ee74d0904947

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

🚓 Slop Cop

✅ Nothing worth flagging. The diff looks consistent with the PR's stated intent and the code-style rules.

Large test-only PR consistent with its stated purpose (splitting workflows tests); no evidence of leaked secrets, debug code, or unintended deletions beyond the described test-file reorganization. No raw diff was available to check STYLE rule violations against added lines.

Automated, non-blocking heads-up from an LLM. It can be wrong — use your judgment. Regenerates on every push.

brunozoric and others added 25 commits October 21, 2026 14:17
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eps as runs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the deleted-review save

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…query counts

Part of removing queries in loops (docs/.bruno/plans/2026-10-21-workflows-no-n-plus-one.md, Phase 1 and Phase 2 item 1). The review lists turn the viewer's read access into query filters (readable models, own-only models by author, denied folders) built once per request, confirm each storage page with one batch read, and never read a target per row. Folder rules load only for models with active reviews (one distinct-values query).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Part of removing queries in loops (docs/.bruno/plans/2026-10-21-workflows-no-n-plus-one.md, Phase 1 item 5 and Phase 2 items 2-6): routing candidates read the target and the folder record once and reuse the listed users; blocking reviews, delete-multiple and delete-workflow paths use one batch call; candidateTeams goes through a request-scoped team loader.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…low user reads

Part of removing queries in loops (docs/.bruno/plans/2026-10-21-workflows-no-n-plus-one.md, Phase 3): the delete cascade lists all records of a batch of reviews at once and deletes in batches with one task-abort call; assignment records are written with a concurrency limit; least-loaded ties read one userId_in list; cancel-for-delete no longer lists twice; saving a workflow reads its user targets with one ListUsers call.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Part of removing queries in loops (docs/.bruno/plans/2026-10-21-workflows-no-n-plus-one.md, Phase 3): the review and assignment repositories delete with CMS DeleteMultipleEntriesUseCase in chunks of 50 instead of one delete per entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review of #6038: abstractions imported under a bare UseCase/Abstraction alias are now aliased XAbstraction, and the review events live in one events.ts per feature (shared payload, union and the step-failed event in shared/events.ts) instead of one file with all eleven. Event names, types and handler tokens are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…uck check

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed user, team, transport or permission lookup in the workflow editor's config use cases was reported as WorkflowPersistenceError ("The workflow could not be read or saved."), pointing at the workflow storage. It is now WorkflowLookupError (Workflows/Workflow/Lookup) with the raw cause kept off the client the same way. A step id missing from a review in NotificationRecipientService.listPool is a ReviewValidationError.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…odes

Review of #6039: the workflow editor access check (signed in, editor permission, a failing permission load as WorkflowLookupError) lives in one WorkflowEditorAccess service used by the eight config use cases; routing loads step members (team members, exclusions, read adapter) in one place for evaluate, listMembers and checkUser, and toStepMembersParams builds the members params for the candidates list and pool notifications.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tside the barrels

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…scan

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… copy

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brunozoric and others added 21 commits October 23, 2026 11:58
…ep clock

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…re on the server

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ver a persistence error

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…moved count

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…stered step type

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eCase

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eview request

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the workflow

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…bin read

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…uplicates

Notification guards, tenant-aware user lookups, paging, stuck-step fallback,
error-leak checks and validation messages now fail when the behaviour breaks;
duplicate and always-true tests are removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ms, and cover a deleted team target

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant