Repository navigation
Conversation
Since 6.5.0 the Translate action in the page list was hidden unless the license granted aiPowerups.websiteBuilder.pageTranslation. Manual translation does not need that license: the translatePage mutation copies the page into the target language with no license check, and the AI decorator falls back to that plain copy when AI translation is off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🚓 Slop Cop ✅ Nothing worth flagging. The diff looks consistent with the PR's stated intent and the code-style rules. Small, focused diff that matches the stated intent (removes a feature-flag gate) with no style or integrity issues. Automated, non-blocking heads-up from an LLM. It can be wrong — use your judgment. Regenerates on every push. |
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
Replaced by 6123 against release/6.5.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Since 6.5.0 the Translate action in the Website Builder page list options menu was only rendered when the license granted
aiPowerups.websiteBuilder.pageTranslation. Projects without AI Powerups lost the action entirely, including the manual flow: copy the page into another language and translate the content by hand. Up to 6.4.0 the action was always shown to users who can create pages.The gate was added in #5536 (
wcp.canUseAiPageTranslation()) and carried over to the feature flag in #5559.Why the gate is not needed
WbMutation.translatePage(TranslatePageUseCaseinapi-website-builder) checks thepagecreate permission and nothing else. It duplicates the page with the target language, path andsourcePageset.WbTranslatePageDecoratorinai-powerupsruns on top of that. When the AI capability is switched off or unavailable it logs and returns the plain copy.So with AI Powerups the page is copied and translated; without it, the page is copied and left for manual translation. Both should have the menu item.
Change
TranslatePageConfigno longer checks the feature flag. TheHasPermission entity="page" action="create"wrapper stays.Testing
yarn lintand a type check ofapp-website-builderpass.Workspace: wby-next3 · page translate menu missing
🤖 Generated with Claude Code