Repository navigation
[2.30] webos: require dlopen and dynamically loaded Wayland - #15
Merged
Merged
Conversation
libpbnjson_c, libhelpers, the Wayland ABI fix library and Wayland are all loaded through SDL_LoadObject(), and the fallbacks for the older libwayland on webOS firmware only exist in the dynamic Wayland loader. Fail configure without SDL_LOADSO, without dlopen, or with Wayland linked directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libpbnjson_c, libhelpers, the Wayland ABI fix library and Wayland itself are all loaded through
SDL_LoadObject(), and the fallbacks for the older libwayland on webOS firmware only exist inSDL_waylanddyn.c. A configure withSDL_LOADSO=OFF, without dlopen, or withSDL_WAYLAND_SHARED=OFFstill succeeded.Fix: in the existing webOS requirements block, fail on each of those.
Verified with the webOS toolchain (CI config, broken ABI ON):
-DSDL_LOADSO=OFF: fails with "webOS requires SDL_LOADSO, but it is disabled"-DHAVE_DLOPEN_IN_LIBC=0 -DHAVE_DLOPEN_IN_LIBDL=0: fails with "webOS requires dlopen, but dlopen was not found"-DSDL_WAYLAND_SHARED=OFF: fails with "webOS requires Wayland to be loaded dynamically, but this build links Wayland directly"🤖 Generated with Claude Code