Skip to content

fix(types): correct intersection and reflection AST resolution #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moshams272 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

fix(types): correct intersection and reflection AST resolution #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions plugins/theme/partials/types.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const union = (arr, sep = '|') =>
const joinTypes = (arr, sep = ' | ') =>
arr?.length ? arr.map(resolve).join(sep) : 'unknown';

const resolve = type => {
Expand All @@ -22,11 +22,13 @@ const resolve = type => {
return resolve(type.elementType) + '[]';

case 'tuple':
return `Tuple< ${union(type.elements, ', ')} >`;
return `Tuple< ${joinTypes(type.elements, ', ')} >`;

case 'union':
return joinTypes(type.types);

case 'intersection':
return union(type.types);
return joinTypes(type.types, ' & ');

case 'optional':
case 'indexedAccess':
Expand All @@ -45,7 +47,7 @@ const resolve = type => {
return resolve(type.element);

case 'reflection':
return 'object';
return type.declaration?.signatures?.length ? 'Function' : 'object';

case 'inferred':
case 'unknown':
Expand Down
Loading