feat(auth): add generic OIDC provider with configurable label and icon - #480
Open
ottonomy wants to merge 1 commit into
Open
feat(auth): add generic OIDC provider with configurable label and icon#480ottonomy wants to merge 1 commit into
ottonomy wants to merge 1 commit into
Conversation
Adds a vendor-neutral `oidc` client registration alongside the existing `okta` and `google` slots, bound to its own OAUTH_OIDC_* variables so the change is fully additive and okta/google behavior is unchanged. Its callback path is /login/oauth2/code/oidc, and its sign-in button label (OAUTH_PROVIDER_NAME) and icon (OAUTH_PROVIDER_ICON_URL or a curated OAUTH_PROVIDER_ICON_SLUG) are configurable — no icon is shown for the generic provider unless one is set, so no vendor mark leaks onto the login page. Drops OAUTH_AUDIENCE from the OAuth activation gate in docker_entrypoint.sh and common.sh (it was required to enable oauth2 but never read; audience is not validated). The generic slot lets a PingFederate deployment migrate to Entra in place, keeping a stable redirect URI. Adds AuthConfigProviderTest (backend) and getIcon cases (UI). Updates the auth doc to introduce the generic provider and frame Okta as one example IdP. ADR: docs/adr/2026-07-21-generic-oidc-provider.md Plan: ~/.skybridge/planning/osmt/2026-07-21-generic-oidc-provider/plan.md Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a vendor-neutral
oidcclient registration alongside the existingoktaandgoogleslots, bound to its own OAUTH_OIDC_* variables so the change is fully additive and okta/google behavior is unchanged. Its callback path is /login/oauth2/code/oidc, and its sign-in button label (OAUTH_PROVIDER_NAME) and icon (OAUTH_PROVIDER_ICON_URL or a curated OAUTH_PROVIDER_ICON_SLUG) are configurable — no icon is shown for the generic provider unless one is set, so no vendor mark leaks onto the login page.Drops OAUTH_AUDIENCE from the OAuth activation gate in docker_entrypoint.sh and common.sh (it was required to enable oauth2 but never read; audience is not validated). The generic slot lets a PingFederate deployment migrate to Entra in place, keeping a stable redirect URI.
Adds AuthConfigProviderTest (backend) and getIcon cases (UI). Updates the auth doc to introduce the generic provider and frame Okta as one example IdP.
ADR: docs/adr/2026-07-21-generic-oidc-provider.md
Plan: ~/.skybridge/planning/osmt/2026-07-21-generic-oidc-provider/plan.md