Skip to content

fix: Enable PHP error logging to stderr#1

Merged
nfebe merged 1 commit into
mainfrom
fix/enable-php-error-logging
Dec 27, 2025
Merged

fix: Enable PHP error logging to stderr#1
nfebe merged 1 commit into
mainfrom
fix/enable-php-error-logging

Conversation

@nfebe

@nfebe nfebe commented Dec 27, 2025

Copy link
Copy Markdown
Contributor

Configure PHP to output errors to stderr so they appear in docker logs. The base FrankenPHP image has log_errors disabled by default.

Settings added:

  • log_errors = On
  • error_log = /proc/self/fd/2
  • error_reporting = E_ALL
  • display_errors = Off

@sourceant

sourceant Bot commented Dec 27, 2025

Copy link
Copy Markdown

Code Review Summary

✨ This pull request makes positive adjustments to both the Dockerfile and README.md. The Dockerfile's structure is improved by logically grouping PHP configurations, and the README.md is enhanced with clearer documentation regarding error logging.

🚀 Key Improvements

  • Improved logical ordering of PHP configurations in Dockerfile.
  • Enhanced user understanding through explicit documentation of PHP error logging in README.md.

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

Comment thread Dockerfile Outdated
Configure PHP to output errors to stderr so they appear in docker logs.
The base FrankenPHP image has log_errors disabled by default.

Settings added:
- log_errors = On
- error_log = /proc/self/fd/2
- error_reporting = E_ALL
- display_errors = Off

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the fix/enable-php-error-logging branch from 8c83eb1 to 796942b Compare December 27, 2025 10:30

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

@nfebe nfebe merged commit f19c59a into main Dec 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant