fix(ci): Add multi-platform build for arm64 support#3
Merged
Conversation
Build workflow now uses per-platform runners (ubuntu-latest for amd64, ubuntu-24.04-arm for arm64) with digest-based push and manifest merge, matching the laravel-docker-dev approach. The tag-latest job now uses imagetools to preserve both platforms. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Code Review SummaryThe PR successfully implements multi-platform support (amd64/arm64) for the FrankenPHP image. It moves away from simple tagging to a more robust digest-based manifest merging strategy. 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| if: github.event_name != 'pull_request' | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: digest-${{ matrix.php }}-${{ matrix.runner }} |
There was a problem hiding this comment.
Using matrix.platform instead of matrix.runner in the artifact name is more descriptive of the actual payload, though the current implementation works.
Suggested change
| name: digest-${{ matrix.php }}-${{ matrix.runner }} | |
| name: digest-${{ matrix.php }}-${{ matrix.platform }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build workflow now uses per-platform runners (ubuntu-latest for amd64, ubuntu-24.04-arm for arm64) with digest-based push and manifest merge, matching the laravel-docker-dev approach. The tag-latest job now uses imagetools to preserve both platforms.