Repository navigation
Terraria: pin wine to its directory and heap fixes; drop a dead process's directory listings - #475
Open
insertfloppy wants to merge 5 commits into
Open
insertfloppy wants to merge 5 commits into
insertfloppy wants to merge 5 commits into
Conversation
…Terraria fixes Pins wine to three Terraria fixes on top of madeira-lgpl (sent to willfaust/wine as their own pull request): - ntdll iOS: read directories by path, not through the shared cwd - ntdll iOS: a directory cache per process, not one shared by all - ntdll: flush blocks handed out by an executable heap from the translator The second keeps the client half of the directory cache per process id. The server reissues the ids of dead processes, so server_init_process_done now calls madeira_dir_cache_flush_pid() next to the fastsync cache's flush, and a new process drops what a dead one with its id left behind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LiLQakAySboBR7FkqkJFKS Signed-off-by: ft7t8drgwf-wq <337626868+ft7t8drgwf-wq@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Cameron · project thread
The Madeira half of the willfaust/wine pull request "ntdll iOS: Terraria runs" (insertfloppy/wine, branch madeira/terraria-dir-and-heap), which gets Terraria (105600)
running on iPhone. Merge after that PR. If you'd rather pin wine in your
next wave, only the server_ios.c change is needed from here.
Changes
df1c5ea5, the current pin): directories read by path instead of through
the shared cwd, a directory cache per process, and executable heap blocks
flushed from the translator.
server_init_process_donecallsmadeira_dir_cache_flush_pid()next tomadeira_fast_flush_pid(). Theserver reissues dead processes' ids, so a new process drops the directory
listings a dead one with its id left behind.
Testing
Confirmed on device (iPhone, sideloaded build 34): Terraria loads its
assets, makes a character, builds a world and plays. That build had the
same changes on the previous wine pin (9129e968). This branch is rebased
onto main e96065a; it is not compiled or device-tested on that base yet.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LiLQakAySboBR7FkqkJFKS