Repository navigation
Retain the CI checks added after the build fixes were merged - #483
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main includes the full final tree from #476, including the required Wine DLL selector fix. Two general checks added during the later PR rollout were still absent.
This PR verifies that the bcrypt, secur32 and crypt32 objects define both native and WoW64 call tables when the static iOS GnuTLS backend is enabled. An empty object now fails at its source build step. The existing app-link test compiles real Mach-O fixtures and rejects each of the six undefined tables.
It also restores the shared Steam connection recovery test step. The step runs when that regression file exists, so feature branches can use the same workflow without importing unrelated Steam code.
The audit found no other missing general CI fixes. Main already has the static TLS flags and the required resource folder references. The Terraria Wine URL and Wine 11.20-only DLL removals belong to their respective feature PRs.
Validation: all six CI host suites, the Unix-library binder test, Bash syntax and git diff checks passed locally. The cache tests cover 4,118 source-change cases, 16 build-setting combinations, and all 128 runtime-component combinations. The full Build IPA run passed for commit 02dab77. CI rebuilt the native app with the TLS object check and validated the complete IPA before upload. The output remains in the GitHub artifact, without an extra local IPA copy. Device installation, live Steam and gameplay are not checked.