fix: ACL bypass via prefix topic matching (CVSS 4.3) - #169
Merged
Merged
Conversation
A literal ACL filter like 'allowed' was treated as matching publish to 'allowed/secret'. MatchTopic returned true after exhausting filter parts without checking whether topic parts remained. Fix: return matched only when len(topicParts) == len(filterParts). The '#' wildcard path already handles multi-level matches correctly. Reported by Team Atlanta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an ACL bypass vulnerability (CVSS 3.1 4.3) reported by Team Atlanta. A literal write ACL like 'allowed' was treated as matching a publish to 'allowed/secret', allowing low-privilege clients to publish to protected child topics.
Root cause: MatchTopic at ledger.go:162 returns true unconditionally after exhausting filter parts, without checking whether topic parts remain.
Fix: return elements, len(topicParts) == len(filterParts). The '#' multi-level wildcard path is unaffected (returns early).
/cc @wind-c