TCrossServer - only adopt AListen.LocalPort when the listen succeeded#184
Open
Vizit0r wants to merge 1 commit into
Open
TCrossServer - only adopt AListen.LocalPort when the listen succeeded#184Vizit0r wants to merge 1 commit into
Vizit0r wants to merge 1 commit into
Conversation
The Listen callback updated FPort with AListen.LocalPort whenever FPort was 0 -- even when the listen attempt failed -- so FPort was silently overwritten with the LocalPort of a failed/garbage listener. The line just above already gates AtomicExchange(FStarted, 1) on ASuccess, and the comment immediately above the FPort line says "extract the actual port AFTER LISTEN SUCCEEDS" -- the code just missed the ASuccess check on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Listen callback updated FPort with AListen.LocalPort whenever FPort was 0 -- even when the listen attempt failed -- so FPort was silently overwritten with the LocalPort of a failed/garbage listener.
The line just above already gates AtomicExchange(FStarted, 1) on ASuccess, and the comment immediately above the FPort line says "extract the actual port AFTER LISTEN SUCCEEDS" -- the code just missed the ASuccess check on this branch.