Skip to content

OpenSSL: fix use-after-free of encrypted send buffer in _SslSend #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vizit0r wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

OpenSSL: fix use-after-free of encrypted send buffer in _SslSend #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Net/Net.CrossSslSocket.OpenSSL.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,13 @@ procedure TCrossOpenSslConnection._SslSendInner(const ABuf: PByte;
if (LEncryptedData <> nil) then
begin
// 锁外发起异步发送, callback 内 CPS 继续推进 (新栈帧, 不在原栈上)
_Send(@LEncryptedData[0], Length(LEncryptedData),
// Use the TBytes overload so the buffer stays alive until the deferred
// send fires. The pointer overload does not copy and the callback closure
// does not capture LEncryptedData -- a use-after-free that's deterministic
// on macOS/Kqueue (allocator reuses the freed slot before transmit) and
// latent on Linux/Epoll and Windows/IOCP. Matches the canonical safe
// pattern documented in TCrossConnectionBase.SendBytes.
_Send(LEncryptedData,
procedure(const AConnection: ICrossConnection; const ASuccess: Boolean)
begin
if not ASuccess then
Expand Down