refactor: move audio player to a separate module (WPB-27633) - #5112
refactor: move audio player to a separate module (WPB-27633)#5112ohassine wants to merge 13 commits into
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
…to-separate-module # Conflicts: # kalium
Test Results2 639 tests 2 639 ✅ 1m 34s ⏱️ Results for commit 256f50e. ♻️ This comment has been updated with latest results. |
…to-separate-module # Conflicts: # kalium
…dule' into move-audio-player-to-separate-module
New ADR(s) in this PR 📚:13. Shared in-app video player as a core moduleDate: 2026-07-16 StatusProposed ContextThe in-app video player ( We now want to play videos in-app when a user taps a video message in a chat. Today the chat The player therefore needs to be consumed by two places:
Because the player is shared UI infrastructure used by multiple layers above DecisionExtract the video player into a new A new dedicated core module is preferred over folding it into the existing The two pieces that are currently cells-specific will be generalized during the move:
The work is sequenced extract-then-reuse, so the risky refactor is validated against the existing
Consequences
|
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (6.57%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #5112 +/- ##
===========================================
- Coverage 52.55% 52.36% -0.20%
===========================================
Files 740 742 +2
Lines 25745 25847 +102
Branches 4224 4233 +9
===========================================
+ Hits 13530 13534 +4
- Misses 10920 11016 +96
- Partials 1295 1297 +2
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
https://wearezeta.atlassian.net/browse/WPB-27633
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Description
media-playertovideo-playerNeeds releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.